Merge branch 'PathOfBuildingCommunity:dev' into dev

Author: jay9297

CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## [v0.21.1](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v0.21.1) (2026/06/20)
+
+[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.21.0...v0.21.1)
+
+
+## What's Changed
+### Fixed Crashes
+- Fix crash when trying to use PoB trader after 0.5.3 [\#2238](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2238) ([vaisest](https://github.com/vaisest))
+### Fixed Calculations
+- Fix more Maximum Rage mod not working [\#2228](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2228) ([Blitz54](https://github.com/Blitz54))
+- Fix general Grenade mods not working [\#2196](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2196) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Blazing Critical not applying as a global buff [\#2221](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2221) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Sine Aequo Immobilisation buildup calculation [\#2222](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2222) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Daze not applying 50% more Stun Buildup [\#2223](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2223) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Overwhelming Presence quality mod multiplying Aura magnitude [\#2224](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2224) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix "+% to Critical Damage Bonus"  mods on weapons applying to Spells [\#2247](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2247) ([luther-rotmg](https://github.com/luther-rotmg))
+### Fixed Behaviours
+- Fix Ice Bite and Innervate only supporting Attacks [\#2207](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2207) ([vaisest](https://github.com/vaisest))
+- Fix power report and trade search not working with Minions [\#2219](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2219) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Bloodhounds Mark not counting the enemy as Marked [\#2220](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2220) ([LocalIdentity](https://github.com/LocalIdentity))
+
+
 ## [v0.21.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v0.21.0) (2026/06/13)
 
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.20.0...v0.21.0)

changelog.txt

@@ -1,3 +1,22 @@
+VERSION[0.21.1][2026/06/20]
+
+--- Fixed Crashes ---
+* Fix crash when trying to use PoB trader after 0.5.3 (vaisest)
+
+--- Fixed Calculations ---
+* Fix more Maximum Rage mod not working (Blitz54)
+* Fix general Grenade mods not working (LocalIdentity)
+* Fix Blazing Critical not applying as a global buff (LocalIdentity)
+* Fix Sine Aequo Immobilisation buildup calculation (LocalIdentity)
+* Fix Daze not applying 50% more Stun Buildup (LocalIdentity)
+* Fix Overwhelming Presence quality mod multiplying Aura magnitude (LocalIdentity)
+* Fix "+% to Critical Damage Bonus"  mods on weapons applying to Spells (luther-rotmg)
+
+--- Fixed Behaviours ---
+* Fix Ice Bite and Innervate only supporting Attacks (vaisest)
+* Fix power report and trade search not working with Minions (LocalIdentity)
+* Fix Bloodhounds Mark not counting the enemy as Marked (LocalIdentity)
+
 VERSION[0.21.0][2026/06/13]
 
 --- New to Path of Building ---

manifest.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <PoBVersion>
-	<Version number="0.21.0" />
+	<Version number="0.21.1" />
 	<Source part="default" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/" />
 	<Source part="runtime" platform="win32" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/runtime/" />
 	<Source part="program" url="https://raw.githubusercontent.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/{branch}/src/" />

spec/System/TestAttacks_spec.lua

@@ -30,6 +30,35 @@ describe("TestAttacks", function()
 		assert.are.equals(2 + 0.25, build.calcsTab.mainOutput.CritMultiplier)
 	end)
 
+	it("local Critical Damage Bonus on a weapon does not apply to spells (issue #2199)", function()
+		-- baseline: a spell's crit multi with a plain quarterstaff (no local crit damage)
+		build.itemsTab:CreateDisplayItemFromRaw([[
+			New Item
+			Razor Quarterstaff
+		]])
+		build.itemsTab:AddDisplayItem()
+		build.skillsTab:PasteSocketGroup("Fireball 20/0  1")
+		build.mainSocketGroup = 1
+		runCallback("OnFrame")
+		local baseSpellCritMulti = build.calcsTab.mainOutput.CritMultiplier
+
+		newBuild()
+
+		-- same spell + quarterstaff, now with a local "+X% to Critical Damage Bonus" affix
+		build.itemsTab:CreateDisplayItemFromRaw([[
+			New Item
+			Razor Quarterstaff
+			+50% to Critical Damage Bonus
+		]])
+		build.itemsTab:AddDisplayItem()
+		build.skillsTab:PasteSocketGroup("Fireball 20/0  1")
+		build.mainSocketGroup = 1
+		runCallback("OnFrame")
+
+		-- the weapon-local crit damage must NOT reach the spell (it isn't using the weapon)
+		assert.are.equals(baseSpellCritMulti, build.calcsTab.mainOutput.CritMultiplier)
+	end)
+
 	it("correctly converts spell damage per stat to attack damage", function()
 		assert.are.equals(0, build.calcsTab.mainEnv.player.modDB:Sum("INC", { flags = ModFlag.Attack }, "Damage"))
 		build.itemsTab:CreateDisplayItemFromRaw([[

spec/System/TestTradeQueryCurrency_spec.lua

@@ -23,6 +23,24 @@ describe("TradeQuery Currency Conversion", function()
 		end)
 	end)
 
+	describe("ReduceOutput", function()
+		it("uses selected minion stats for weighted result comparison", function()
+			mock_tradeQuery.statSortSelectionList = { { stat = "AverageDamage" } }
+
+			local result = mock_tradeQuery:ReduceOutput({
+				AverageDamage = 10,
+				Life = 100,
+				Minion = {
+					AverageDamage = 250,
+					Life = 200,
+				},
+			})
+
+			assert.are.equals(250, result.AverageDamage)
+			assert.is_nil(result.Life)
+		end)
+	end)
+
 	describe("PriceBuilderProcessPoENinjaResponse", function()
 		-- Pass: Processes without error, restoring map while adding a notice
 		-- Fail: Corrupts map or crashes, indicating fragile API response handling, breaking future conversions

spec/System/TestTradeQueryGenerator_spec.lua

@@ -34,6 +34,50 @@ describe("TradeQueryGenerator", function()
 			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
 			assert.are.equal(result, 100)
 		end)
+
+		it("uses minion output for non-FullDPS stats when minion output is available", function()
+			local baseOutput = { AverageDamage = 10, Minion = { AverageDamage = 100 } }
+			local newOutput = { AverageDamage = 10, Minion = { AverageDamage = 250 } }
+			local statWeights = { { stat = "AverageDamage", weightMult = 1 } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+
+			assert.are.equal(result, 2.5)
+		end)
+
+		it("uses player output for FullDPS even when minion output is available", function()
+			local baseOutput = { FullDPS = 100, Minion = { FullDPS = 100 } }
+			local newOutput = { FullDPS = 250, Minion = { FullDPS = 1000 } }
+			local statWeights = { { stat = "FullDPS", weightMult = 1 } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+
+			assert.are.equal(result, 2.5)
+		end)
+
+		it("uses the fallback DPS ratio once when FullDPS is unavailable", function()
+			local baseOutput = { Minion = { TotalDPS = 10, TotalDotDPS = 0, CombinedDPS = 10 } }
+			local newOutput = { Minion = { TotalDPS = 25, TotalDotDPS = 0, CombinedDPS = 25 } }
+			local statWeights = { { stat = "FullDPS", weightMult = 1 } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+
+			assert.are.equal(result, 2.5)
+		end)
+
+		it("falls back to player output when the selected stat is not on minion output", function()
+			local baseOutput = { Spirit = 100, Minion = { AverageDamage = 100 } }
+			local newOutput = { Spirit = 120, Minion = { AverageDamage = 100 } }
+			local statWeights = { { stat = "Spirit", weightMult = 1 } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+
+			assert.are.equal(result, 1.2)
+		end)
 	end)
 
 	describe("Filter prioritization", function()

spec/System/TestTreeTab_spec.lua

@@ -146,4 +146,22 @@ describe("TreeTab", function()
 			assert.is_nil(build.treeTab.specList[1].allocNodes[2])
 		end)
 	end)
+
+	describe("Power stat calculation", function()
+		it("uses minion output for non-FullDPS stats when minion output is available", function()
+			local selection = { stat = "AverageDamage" }
+			local outputWithNode = { AverageDamage = 10, Minion = { AverageDamage = 250 } }
+			local baseOutput = { AverageDamage = 10, Minion = { AverageDamage = 100 } }
+
+			assert.are.equals(150, build.calcsTab:CalculatePowerStat(selection, outputWithNode, baseOutput))
+		end)
+
+		it("uses player output for FullDPS even when minion output is available", function()
+			local selection = { stat = "FullDPS" }
+			local outputWithNode = { FullDPS = 250, Minion = { FullDPS = 1000 } }
+			local baseOutput = { FullDPS = 100, Minion = { FullDPS = 1000 } }
+
+			assert.are.equals(150, build.calcsTab:CalculatePowerStat(selection, outputWithNode, baseOutput))
+		end)
+	end)
 end)

src/Classes/CalcsTab.lua

@@ -672,7 +672,7 @@ function CalcsTabClass:PowerBuilder()
 end
 
 function CalcsTabClass:CalculatePowerStat(selection, original, modified)
-	if modified.Minion and not selection.stat == "FullDPS" then
+	if modified.Minion and selection.stat ~= "FullDPS" then
 		original = original.Minion
 		modified = modified.Minion
 	end

src/Classes/Item.lua

@@ -1866,9 +1866,9 @@ function ItemClass:BuildModListForSlotNum(baseList, slotNum)
 			weaponData[value.key] = value.value
 		end
 		for _, mod in ipairs(modList) do
-			-- Convert accuracy, L/MGoH and PAD Leech modifiers to local
+			-- Convert accuracy, crit damage bonus, L/MGoH and PAD Leech modifiers to local
 			if (
-				(mod.name == "Accuracy" and mod.flags == 0) or (mod.name == "ImpaleChance" and mod.flags ~= ModFlag.Spell) or
+				(mod.name == "Accuracy" and mod.flags == 0) or (mod.name == "CritMultiplier" and mod.flags == 0) or (mod.name == "ImpaleChance" and mod.flags ~= ModFlag.Spell) or
 				((mod.name == "LifeOnHit" or mod.name == "ManaOnHit") and mod.flags == ModFlag.Attack) or
 				((mod.name == "PhysicalDamageLifeLeech" or mod.name == "PhysicalDamageManaLeech") and mod.flags == ModFlag.Attack)
 			   ) and (mod.keywordFlags == 0 or mod.keywordFlags == KeywordFlag.Attack) and not mod[1] then

src/Classes/ItemsTab.lua

@@ -702,12 +702,13 @@ holding Shift will put it in the second.]])
 	end
 
 	-- Section: Affix Selection
+	local maxModCount = 9
 	self.controls.displayItemSectionAffix = new("Control", {"TOPLEFT",self.controls.displayItemSectionRune,"BOTTOMLEFT"}, {0, 0, 0, function()
 		if not self.displayItem or not self.displayItem.crafted then
 			return 0
 		end
 		local h = 6
-		for i = 1, 6 do
+		for i = 1, maxModCount do
 			if self.controls["displayItemAffix"..i]:IsShown() then
 				h = h + 24
 				if self.controls["displayItemAffixRange"..i]:IsShown() then
@@ -717,7 +718,7 @@ holding Shift will put it in the second.]])
 		end
 		return h
 	end})
-	for i = 1, 6 do
+	for i = 1, maxModCount do
 		local prev = self.controls["displayItemAffix"..(i-1)] or self.controls.displayItemSectionAffix
 		local drop, slider
 		local function verifyRange(range, index, drop) -- flips range if it will form discontinuous values