feat: add drag-and-drop reordering for gem slots and gem selector improvements#54
Closed
jay9297 wants to merge 2 commits into
Closed
feat: add drag-and-drop reordering for gem slots and gem selector improvements#54jay9297 wants to merge 2 commits into
jay9297 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Drag & Drop
Implements dead-reckoning drag reordering with 5px threshold for insertion detection. Renders an insertion line indicator between slots during drag. Properly resyncs all slot widgets after reorder via gemList reorganization.
Gem Selector
activeOnlyfilter added to GemSelectClass constructor for slot 1, preventing support gems from appearing as main active skillsSupport Gem Level/Quality Disable
Verified via poe2wiki.net: PoE2 support gems use tiers (I/II/III), not levels or quality. All 557 support gems have
naturalMaxLevel = 1and emptyqualityStatsblocks. The level/quality controls are now properly disabled when a support gem is selected.Test plan