Sync with upstream#59
Merged
Merged
Conversation
Some old mods don't require the socketed in text Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…nd III, Infernal Cry, and "Ancestrally Boosted Attacks" passive nodes (#1839) * add support for Ancestral Call, Crescendo II and III, ancestral boost tree nodes * fix ancestral call inc dmg from tree * big ole refactor so we stop duplicating code one commit so I can revert if it goes boom * added test update CalcSection from "Exerted Warcries" to "Ancestral Boosts" * add data map for gemName given a modSource * boosted attacks configOption * add support for Ancestral Empowerment, including combining Ancestral Empowerment with Fist of War fix Fist of War/ancestrally boosted slams more AOE to inc AOE add test for Combined logic for Ancestral Empowerment and Fist of War * comment spelling * better label * fix avg aoe from fist of war * forgot AOE portion for Crescendo III * add support for Infernal Cry's empowered buff * refactor away from specific baseMod for FistOfWar fix Ancestral Empowerment not getting the double from fist of war III * empowered condition for all Ancestrally Boosted * ancestralBoostEffect * multiplier instead * pr comments also refactored Crescendo III to use the new logic instead of an extra isolated block of logic by introducing a way to conditionally max uptime for Boosted or Empowered attacks * Fix issues Move the Infernal Cry buff to calc offence so it doesn't rely on stale calc output Fix Ancestral Empowerment uptime calculation Move gain table so Infernal Cry still works * Fix spelling --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Passive tree parser from ggg web data * enhanced escapeGGGString * Fix ascendancy unlock constraint check in node search parameters * Refactor DrawQuadAndRotate to handle different data lengths for vertex calculations * Add node overlay for Blighted Notable Frames in passive tree * Fix typos and improve comments in passive tree script * Fix typos in ascendancy handling and update inner radius calculations in passive tree script * Refactor passive tree node replacement logic and add switchable options for Druid nodes * Add support for alias notable maps and enhance jewel socket handling - Enhanced passivetree_ggg.lua to support aliasNotableMap for jewel sockets. * Rename aliasNotableMap to aliasPassiveSocket for clarity in passive tree data * Enhance jewel socket handling by adding noRadius property and updating related logic in passive tree * Enable Abyssal Lich parser * Fix tests Export ModCache Fix crash with class Ids Fix unarmed data for Ids * Add legacy class ID remap Old builds from 0.1 to 0.3 used the wrong id for the character class and opening them now would convert them to the wrong class. This maps the old builds so they now open correctly * Formatting + typos * AliasPassiveSocket fix Was using the wrong name from a previous commit * Export fixes Uses the tree data folder to look for the ggg assets and json files Fixes the tree file changing each time on export due to pairs usage * Use copy file command to speed up export Now runs in 0.1s instead of 8s --------- Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…astery nodes (#1998) Co-authored-by: justjuangui <servicios@juacarvajal.com>
* Fixes the damage calculation for Spectres and Tamed Beasts Spectres and Tamed Beasts use the monster damage values for their base damage stats but in an effort for GGG to have them equal the minion stats at the same level they have added a global damage multiplier to make them even e.g. For level 42 monster Monster Damage: 97.1 Minion Damage: 230.37 (2.37x) So the spectre needs a 137% more damage multiplier I also rolled the 25% more damage server side mod into this calc so that they are in 1 place * Multiply all minion attack damage by minion multiplier All minions are meant to have their attack damage multiplied by the minions innate damage multiplier Currently we were only applying that damage multiplier to the innate physical damage of the hit Currently this mechanic is bugged for Spectres and Tamed Beasts and working how we currently have the code but this will be fixed by GGG next week in a patch * Fix damage multi not applying to the minion directly * Fix test --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…Roar's Empower mod, and some 0.5 passive nodes (#1985) * add support for Empty Roar empower mod add support for a few 0.5 tree nodes like totems have no cost and the rewording of eldritch battery fix stat scaling bug with Heavy Armour notable * lol ggg removed the no cost * update empty roar parse with MaxUptimeRatio * update for double mana cost wording update a few piecemeal for new wording add parsing for The Catha's Balance * Fix Catha's node not working --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add support for 0.5 mods of Blistering Bond Add test Remove tag from old test * update calcSection * fix merge * indent
Add breakdown Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* remove gems that are no longer in game * modcache fix tests * lmao didn't commit test fixes * Revert "remove gems that are no longer in game" This reverts commit b84d0ae. * use legacy tag instead of deleting gems update SkillsTab for legacy toggle * legacy tag the 0.5 changes, remove Not in Game --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
When dual wielding the override mod would set the crit chance of the second weapon to 100% which would mess with the calcs and the breakdown Also renamed all the variables to be Inevitable critical hits
* Skill icons * Fix icon names and export on skills * More updates to tooltip * More pretty stuff * Fix size of bg image * Small color fix for reqs * Unique hem header for Lineage gems * remove ConPrintf * Add indents to tooltip, fix header image, fix aoe search term for skills * Move asset packing logic out of tree file Moves the asset logic away from being just in the tree file so that we can generate files Moves the monster category icons out of the tree file and the 0.5 JSON tree breaks it --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
#1778) * Add support for thorns crit and ignore armour passives * Add thorns damage support and thorns-based support interactions * Fix thorns ailment handling and mana scaling (modflag not yet implemented) * Removed CannotBleed and CannotPoison from ThornsPlayer * Added support for Stag Idol's Bonded modifier (Thorns Damage has 40% chance to ignore Enemy Armour) * Update to use ModFlag.Thorns Changed the calcs to use a ModFlag as it reduces the amount of extra code required Still need to fix implementation for when Thorns damage is applied to hits * Fix crash * Fix Thornskin not working * Fix Quill Burst thorns damage calculation * Fix Quill Burst support so it won't be overwritten when re-exporting skills data * Support for Crackling Barrier support * Support for thorns damage from Scavenged Plating * Fix Quill Burst damage calculation more/better? * Fix thorns damage calculation to consider thorns-flagged skills * Add basic Barbs support, make Thorns skill unsupportable, remove some unused code * Fix issue Add back logic to hide thorns skill unless you have base damage in your build Fix calc offence logic and remove extra lines * Fix thorns mod finding logic * Fix Blistering Bond test --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: DragoonWraith (github: krryan) <dragoonwraith@gmail.com> Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
* Prepare release 0.16.0 * Fix changelogs --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
--- 0.5 Return of the Ancients --- * Add support for 0.5 skill tree (trompetin17) * Add support for Spirit Walker's The Catha's Balance, The Empty Roar's Empower mod, and some 0.5 passive nodes (Peechey) * Add support for new Blistering Bond mods (Peechey) * Update Culling Strike Implementation (Peechey) * Update Deflection formula (Edvinas-Smita) --- New to Path of Building --- * Add initial support for Thorns calculations (DS-Koala) * Add build comparison tab (oboking, vaisest) * Add support for advanced copy/paste (Wires77) * Add Loadout management UI (FenikSRT4) * Add OAuth support, fixes many local and essence mods, add price sorting, and add radius jewels to the trader tool (vaisest) * Add gem tooltips for tree nodes that grant skills (vaisest) * Update Gem tooltips to look more like in game (Blitz54) * Add support for Exposure on many skills (LocalIdentity) * Copy anoints and augments when comparing items, also change jewel socket comparison order (vaisest) * Add support for Ancestral Empowerment and Ancestrally Boosted mechanics (Peechey) * Add Desecrated mods to Custom modifiers dropdown (Blitz54) * Add stat sorting to mod and corruption lists (mcagnion) * Add support for double Corrupting + fix corruptions removing anoints (vaisest) * Add support for corrupting gems for +/- 1 level (Blitz54) * Add node description tooltip to Power Report (Peechey) * Add support for fractional Full DPS counts * Remember league for imported characters (Wires77) * Add progress bar to power report (ALameLlama) * Auto set Minion count in your presence based on skill gems in build (LocalIdentity) * Add 0.4 Uniques (Blitz54) * Add Talisman preset to rare item list (LocalIdentity) --- Tree --- * Add support for Witchhunter's Sorcery Ward and Ceremonial Ablution (Peechey) * Add support for Inevitable Critical hits (Dimencia) * Add support for Tactician's Strategic Embankments totem Auras (Peechey) * Add support for Lich's Price of Power, Stormweaver's Multiplying Squalls, and Acolyte of Chayula's Unravelling (Peechey) * Add support for Deadeye's Thrilling Chase and Heightened Charges support (Peechey) * Add support for Commanding Rage and Expendable Army passive nodes (Peechey) * Add support for Abyssal Lich's Eldritch Empowerment, Umbral Well, and Unwilling Offering (Peechey) * Add support for Into the Breach purple flames (greatnameincoming, LocalIdentity) * Add support for Lord of the Wilds reservation efficiency mod (ibabde) * Add support for Trusted Kinship non-companion skill reservation efficiency (Eucelia) * Add support for Ancestral Bond's Spirit Reservation (Peechey) --- Skills --- * Add DPS calculation for Firestorm, Rain of Arrows, Icestorm, Thunderstorm and Volcano (MrHB212) * Add support for the Decompose Poison Cloud (TarikBeentjes61) * Add support for many Lineage mods (Peechey) * Add support for Thunderstorm's Drenched mods (Peechey) * Add support for Ritualistic Curse's More Delay (Peechey) * Add support for Biting Frost and Glacial Cascade's Final Burst (Peechey) * Add support for Zenith (Peechey) * Add support for Zarokh's Revolt (Peechey) * Add support for Temporal Chains (Peechey) * Add support for Dark Effigy DPS scaling with Chaos Debuffs on enemy (LocalIdentity) * Add support for Flicker Strike and various support gems (vaisest) * Add support for Pinnacle of Power (Peechey) * Add support for Expand (Peechey) * Add support for Flame Wall's Projectile Buff (Peechey) * Add Mirage Deadeye gem (vaisest) --- Items --- * Add support for Tabula Rasa and Sekhema's Resolve (Peechey) * Add support for The Vertex "skill gems have no attribute requirement" (Blitz54) * Add support for Jarngreipr's Strength mod (Peechey) * Add support for Sacrosanctum's Energy Shield Recoup mod (Peechey) * Add support for Silks of Veneration and The Mutable Star's Current Energy Shield mods (Peechey) * Add support for Strugglescream (Peechey) * Add support for Solus Ipse's Lineage Support mod (Peechey) * Add support for Prisoner's Manacles and Sine Aequo's Immobilise mods and Kaltenhalt's Freeze Buildup for Parry mod (Peechey) * Add support for many "All Damage can Contribute" mods (Peechey) * Add support for many Unique mods (Peechey) * Add support for Ironbound unique mods (Peechey) * Add support for Liminal Coil unique mods (Peechey) * Add support for Twisted Empyrean, Periphery, and Sylvan's Effigy unique mods (Peechey) * Add support for Lethal Draw's Added Phys from Flask mod and Totem Max Elemental Res nodes (Peechey) --- Mods --- * Add support for 'Non-Channelling Spells have 3% increased Magnitude of Ailments per 100 maximum Life' (jacul) * Add support for damage per combo mods (Eucelia) * Add support for Legacy Grand Spectrum mods (LocalIdentity) --- Fixed Crashes --- * Fix crash when importing some builds to party tab * Fix crash on import from private league (LocalIdentity) * Fix crash on loading build due to some minion skills (LocalIdentity) * Fix crash when opening some old builds (LocalIdentity) * Fix Adnonia's Ego power charge mod slider crash (LocalIdentity) --- User Interface --- * Add legacy toggle for gems that are no longer obtainable (Peechey) * Show "The Unseen Paths" nodes only when allocated (MrHB212) * Show Sanctified text on tooltip (Blitz54) * Add "aoe" filtering for gem search (Blitz54) * Dynamically position elements in items tab (meehl) * Fix import and crafting text colour (Blitz54) * Fix Ascendancy and Loadout Dropdowns visibility on smaller screens (Peechey) * Fix Rage tooltip (Eucelia) * Fix options menu overflowing screen boundaries (majochem) * Fix tooltip positioning and size for multi-column tooltips (majochem) --- Fixed Calculations --- * Fix the damage calculation for Spectres, Tamed Beasts and some minions (LocalIdentity) * Fix support gems importing as level other than 1 (Blitz54) * Fix Blasphemy rounding (Blitz54) * Fix scaling for Inexorable Critical II (Peechey) * Fix Projectile Spell Block eHP * Fix calculation of some stats when using Ingenuity (LocalIdentity) * Fix generic Minion damage mods applying to Inspiring Ally * Fix Undying Hate attribute passive bonuses not working * Fix Palm skills not using Quarterstaff Damage and Crit * Fix Flame Breath attack rate calculation (LocalIdentity) * Fix damage taken sorting on tree and unique list (LocalIdentity) * Fix Charm quality applying to effect instead of duration (LocalIdentity) * Fix increased Enemy damage taken mods doubling their affect in Ailment calcs (Andrew-Klotz) --- Fixed Behaviours --- * Fix eHP value sometimes decreasing when allocating defence nodes (LocalIdentity) * Fix persistent buff supports of the same category not stacking (Peechey) * Fix pasted items not selecting correct runes (LocalIdentity) * Fix weapon set allocation issues + add colour to nodes (LocalIdentity) * Fix Item granted skills not showing up as Implicits when pasting (LocalIdentity) * Fix Minion Pact damage applying without nearby minions (LocalIdentity) * Fix Rage Regeneration not granting the Rage damage effect (TarikBeentjes61) * Fix offhand weapon unequip during node power process with Giant's Blood (LocalIdentity) * Fix Mace Strike import and "Two Hand" naming on items (Blitz54) * Fix low life defence mods not applying sometimes when using Starkonja's, Rise of the Phoenix and Coward Legacy (NamNgHH) * Fix some build site links not working (Peechey) * Fix missing Eternal Mark support (Peechey) * Fix Corrupted Blood config not showing for Corrupting Cry Supports (Peechey) * Fix item-granted skills counting toward socket group limit (LocalIdentity) * Fix Uhtred supports counting Meta gems as supports * Fix Barrage incorrectly granting damage to some skills * Fix Stomping Ground and Ferocious Roar not working when using a Talisman (LocalIdentity) * Fix "against Enemies within 2m" mods not applying unless distance was exactly 2m (avtobus32) * Fix many skills not enabling the Wither config option (krryan) * Fix Essence mod list when using a Quarterstaff (vaisest) * Fix URL spoofing issue with imported URLs (Wires77) --- Accuracy Improvements --- * Remove weapon bases that did not exist yet (Blitz54) * Fix parsing of Molten One's Gift fire damage Armour Break mod (Eucelia) * Fix Keeper of the Arc legacy mod value (Blitz54) * Fix Show All Configurations hiding some options * Fix Effigy of Cruelty missing Critical Weakness mod (Blitz54) * Fix variant text ordering for The Adorned and Yoke of Suffering (poikende)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: