docs: rewrite CLAUDE.md and AGENTS.md to match actual repo state#65
Merged
Conversation
- Fix test commands: compose service is 'busted-tests', not 'tests'; add --exclude-tags/--filter usage and the read-only-volume coverage caveat - Fix paths: calc engine is flat src/Modules/Calc*.lua (no Calcs/ dir), ModParser tests live in spec/System/TestModParser_spec.lua - Add architecture overview: entry points, modifier system (ModParser/ ModDB/mod syntax), calculation pipeline incl. per-hand output passes, generated game data, and pointers to docs/ - Document CI matrix, 370-success baseline and known TestWard failures - Carry over fork/PR rules from AGENTS.md; make the code-review-graph MCP section conditional on tool availability https://claude.ai/code/session_01EitwohXyFktgKuxdvwgYHY
|
🔄 Cycle 1, attempt 1/3 |
The spellcheck dictionary doesn't know 'callees' or the lowercase GHCR image path components; the image name must stay lowercase, so ignore them inline. https://claude.ai/code/session_01EitwohXyFktgKuxdvwgYHY
|
🔄 Cycle 1, attempt 1/3 |
Same fixes as the CLAUDE.md rewrite: correct compose service name (busted-tests), correct test file names (TestModParser_spec.lua), calc engine is flat src/Modules/Calc*.lua (no Calcs/ dir), drop the inaccurate 'tests/ is the Docker harness' claim, add the coverage read-only-volume caveat, test baseline, per-hand pass gotcha, and make the code-review-graph MCP section conditional on availability. https://claude.ai/code/session_01EitwohXyFktgKuxdvwgYHY
jay9297
changed the title
|
🔄 Cycle 1, attempt 1/3 |
jay9297
marked this pull request as ready for review
June 11, 2026 02:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites
CLAUDE.md(and applies the same corrections toAGENTS.md) so the guidance given to AI assistants matches the repository as it actually is. The previous version had several commands and paths that no longer (or never) worked:busted-tests, nottests(docker compose run --rm testsfails). Added the CI-equivalent unit invocation (--exclude-tags builds,data),--filterfor running a single test, and the caveat that--coveragecan't writeluacov.report.outthrough compose because the volume is mounted read-only (CI uses a separatedocker runfor this).src/Modules/Calcs/directory; the calc engine is the flatsrc/Modules/Calc*.luafiles. ModParser tests live inspec/System/TestModParser_spec.lua(notTestModParser.lua).tests/is a small Python test forfix_ascendancy_positions.py, not the Docker harness, so that claim was dropped.Launch.luavsHeadlessWrapper.lua), the modifier system (ModParser→mod()syntax →ModDB/ModList), the calculation pipeline including the per-handoutput/globalOutput/combineStatpass model fromdocs/calcOffence.md, the generated nature ofsrc/Data/viasrc/Export/, and pointers to thedocs/tutorials.devplus the two knownTestWard_spec.luafailures, so assistants don't "fix" them by weakening assertions.jay9297/PathOfBuilding-PoE2dev; noted theai-fix/ai-review/auto-mergeworkflows. AGENTS.md keeps its push-default and upstream-sync rules..mcp.json), so both files now tell assistants to use those tools when available and fall back to standard tools otherwise, instead of unconditionally mandating tools that may not exist in a session.cspell:ignoredirectives forcalleesand the lowercase GHCR image path, which aren't in the external dictionary.https://claude.ai/code/session_01EitwohXyFktgKuxdvwgYHY