Skip to content

fix(ci): properly skip ai-review steps when diff exceeds 3000 lines #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jay9297 merged 3 commits into from
Jun 13, 2026
Merged

fix(ci): properly skip ai-review steps when diff exceeds 3000 lines #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31790d0
fix: add contents:write permission to beta workflow
claude Jun 12, 2026
7b2742a
fix(ci): properly skip downstream steps when diff exceeds 3000 lines
claude Jun 12, 2026
2fbb1d8
Merge branch 'dev' into claude/github-actions-failure-6firsu
jay9297 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ai-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,17 @@ jobs:
git diff --stat "origin/${{ github.base_ref }}...HEAD" > /tmp/pr.summary

- name: Guard against oversized diff
id: size-check
run: |
LINES=$(wc -l < /tmp/pr.diff)
echo "Diff size: ${LINES} lines"
if [[ "$LINES" -gt 3000 ]]; then
echo "::warning::Diff exceeds 3000 lines — skipping AI review"
exit 0
echo "skip=true" >> "$GITHUB_OUTPUT"
fi

- name: Build review prompt
if: steps.size-check.outputs.skip != 'true'
run: |
cat > /tmp/review-prompt.txt << 'PROMPT_EOF'
You are a senior Lua developer reviewing a Path of Building 2 PR. Follow CLAUDE.md.
Expand Down Expand Up @@ -83,12 +85,13 @@ jobs:
cat /tmp/pr.diff >> /tmp/review-prompt.txt

- name: Run AI review
if: steps.size-check.outputs.skip != 'true'
run: |
source scripts/agent-lib.sh
run_agent_with_fallback /tmp/review-prompt.txt review 20 > /tmp/review.md

- name: Save review artifact
if: always()
if: always() && steps.size-check.outputs.skip != 'true'
uses: actions/upload-artifact@v4
with:
name: ai-review-${{ github.event.pull_request.number }}-${{ github.run_attempt }}
Expand All @@ -97,12 +100,14 @@ jobs:

- name: Parse verdict
id: verdict
if: steps.size-check.outputs.skip != 'true'
run: |
VERDICT=$(grep '^VERDICT:' /tmp/review.md | tail -1 | cut -d: -f2 || echo "COMMENT")
sed -i '/^VERDICT:/d' /tmp/review.md
echo "result=${VERDICT}" >> "$GITHUB_OUTPUT"

- name: Post or update review comment
if: steps.size-check.outputs.skip != 'true'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUM: ${{ github.event.pull_request.number }}
Expand All @@ -126,6 +131,7 @@ jobs:
fi

- name: Submit formal review
if: steps.size-check.outputs.skip != 'true'
continue-on-error: true
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Loading