fix: re-architecture release workflow to prevent race conditions and ensure all 5 platform binaries are bundled

Author: jayeshmepani

.github/workflows/release-prebuilt-libs.yml

@@ -24,13 +24,11 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y build-essential curl autoconf automake libtool pkg-config git
       - name: Compile shared library
         run: bash build/compile-linux.sh
-      - name: Create release archive
-        run: tar -czf build/libpostal-linux-x64.tar.gz -C postalkit/libs/linux-x64 libpostal.so
       - name: Upload workflow artifact
         uses: actions/upload-artifact@v4
         with:
           name: libpostal-linux-x64
-          path: build/libpostal-linux-x64.tar.gz
+          path: postalkit/libs/linux-x64/libpostal.so
 
   build-linux-arm64:
     name: Build Linux arm64
@@ -41,13 +39,11 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y build-essential curl autoconf automake libtool pkg-config git
       - name: Compile shared library
         run: bash build/compile-linux.sh
-      - name: Create release archive
-        run: tar -czf build/libpostal-linux-arm64.tar.gz -C postalkit/libs/linux-arm64 libpostal.so
       - name: Upload workflow artifact
         uses: actions/upload-artifact@v4
         with:
           name: libpostal-linux-arm64
-          path: build/libpostal-linux-arm64.tar.gz
+          path: postalkit/libs/linux-arm64/libpostal.so
 
   build-macos-x64:
     name: Build macOS x64
@@ -58,13 +54,11 @@ jobs:
         run: brew install autoconf automake libtool pkg-config
       - name: Compile shared library
         run: bash build/compile-macos.sh
-      - name: Create release archive
-        run: tar -czf build/libpostal-macos-x64.tar.gz -C postalkit/libs/macos-x64 libpostal.dylib
       - name: Upload workflow artifact
         uses: actions/upload-artifact@v4
         with:
           name: libpostal-macos-x64
-          path: build/libpostal-macos-x64.tar.gz
+          path: postalkit/libs/macos-x64/libpostal.dylib
 
   build-macos-arm64:
     name: Build macOS arm64
@@ -75,13 +69,11 @@ jobs:
         run: brew install autoconf automake libtool pkg-config
       - name: Compile shared library
         run: bash build/compile-macos.sh
-      - name: Create release archive
-        run: tar -czf build/libpostal-macos-arm64.tar.gz -C postalkit/libs/macos-arm64 libpostal.dylib
       - name: Upload workflow artifact
         uses: actions/upload-artifact@v4
         with:
           name: libpostal-macos-arm64
-          path: build/libpostal-macos-arm64.tar.gz
+          path: postalkit/libs/macos-arm64/libpostal.dylib
 
   build-windows-x64:
     name: Build Windows x64
@@ -97,17 +89,14 @@ jobs:
       - name: Compile shared library
         shell: msys2 {0}
         run: bash build/compile-windows.sh
-      - name: Create release archive
-        shell: pwsh
-        run: Compress-Archive -Path postalkit\libs\windows-x64\postal.dll -DestinationPath build\libpostal-windows-x64.zip -Force
       - name: Upload workflow artifact
         uses: actions/upload-artifact@v4
         with:
           name: libpostal-windows-x64
-          path: build/libpostal-windows-x64.zip
+          path: postalkit/libs/windows-x64/postal.dll
 
-  upload-release-assets:
-    name: Upload Release Assets & Commit to Repo
+  release-and-commit:
+    name: Create GitHub Release and Commit Binaries
     needs: [build-linux-x64, build-linux-arm64, build-macos-x64, build-macos-arm64, build-windows-x64]
     runs-on: ubuntu-latest
     steps:
@@ -116,15 +105,35 @@ jobs:
         with:
           ref: main
 
-      - name: Download all artifacts
+      - name: Download all binaries
         uses: actions/download-artifact@v4
         with:
-          path: dist
-          merge-multiple: true
+          path: postalkit/libs
+          merge-multiple: false
 
-      - name: Generate Checksums
+      - name: Restructure downloaded artifacts
         run: |
-          cd dist
+          # The artifacts are downloaded into folders named after the artifact name.
+          # We need to move the actual files into the correct postalkit/libs structure.
+          mv postalkit/libs/libpostal-linux-x64/libpostal.so postalkit/libs/linux-x64/
+          mv postalkit/libs/libpostal-linux-arm64/libpostal.so postalkit/libs/linux-arm64/
+          mv postalkit/libs/libpostal-macos-x64/libpostal.dylib postalkit/libs/macos-x64/
+          mv postalkit/libs/libpostal-macos-arm64/libpostal.dylib postalkit/libs/macos-arm64/
+          mv postalkit/libs/libpostal-windows-x64/postal.dll postalkit/libs/windows-x64/
+          
+          # Clean up the empty artifact folders
+          rm -rf postalkit/libs/libpostal-*
+
+      - name: Create Release Archives
+        run: |
+          mkdir -p dist_archives
+          tar -czf dist_archives/libpostal-linux-x64.tar.gz -C postalkit/libs/linux-x64 libpostal.so
+          tar -czf dist_archives/libpostal-linux-arm64.tar.gz -C postalkit/libs/linux-arm64 libpostal.so
+          tar -czf dist_archives/libpostal-macos-x64.tar.gz -C postalkit/libs/macos-x64 libpostal.dylib
+          tar -czf dist_archives/libpostal-macos-arm64.tar.gz -C postalkit/libs/macos-arm64 libpostal.dylib
+          zip -j dist_archives/libpostal-windows-x64.zip postalkit/libs/windows-x64/postal.dll
+          
+          cd dist_archives
           for file in *; do sha256sum "$file" > "${file}.sha256"; done
 
       - name: Resolve target tag
@@ -140,51 +149,35 @@ jobs:
         uses: softprops/action-gh-release@v2
         with:
           tag_name: ${{ steps.target.outputs.tag }}
-          files: dist/*
+          files: dist_archives/*
           fail_on_unmatched_files: true
 
       - name: Commit Binaries to Repository
         run: |
-          # 1. Clean out archives from the folders
-          mkdir -p postalkit/libs/linux-x64 postalkit/libs/linux-arm64 postalkit/libs/macos-x64 postalkit/libs/macos-arm64 postalkit/libs/windows-x64
-          
-          # 2. Extract the actual library files into their git folders
-          tar -xzf dist/libpostal-linux-x64.tar.gz -C postalkit/libs/linux-x64
-          tar -xzf dist/libpostal-linux-arm64.tar.gz -C postalkit/libs/linux-arm64
-          tar -xzf dist/libpostal-macos-x64.tar.gz -C postalkit/libs/macos-x64
-          tar -xzf dist/libpostal-macos-arm64.tar.gz -C postalkit/libs/macos-arm64
-          unzip -o dist/libpostal-windows-x64.zip -d postalkit/libs/windows-x64
-
-          # 3. Push to main branch
           git config --local user.name "github-actions[bot]"
           git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
           git add --force postalkit/libs/
-          git commit -m "chore: populate prebuilt binaries in libs/ directory [skip ci]" || echo "No changes to commit"
+          git commit -m "chore: bundle prebuilt binaries for all 5 platforms [skip ci]" || echo "No changes to commit"
           git push origin main
 
   publish-to-pypi:
     name: Publish Final Package to PyPI
-    needs: [upload-release-assets]
+    needs: [release-and-commit]
     runs-on: ubuntu-latest
     permissions:
       id-token: write
       contents: read
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: main # Pull the latest main with the committed binaries
-      
+          ref: main
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: "3.10"
-          
       - name: Install build tools
         run: python -m pip install --upgrade pip build
-        
       - name: Build and Publish
-        run: |
-          python -m build
-          
+        run: python -m build
       - name: Publish package to PyPI
         uses: pypa/gh-action-pypi-publish@release/v1