Skip to content

Commit def301c

Browse files
jaypatrickclaudeCopilot
authored
fix(typescript): resolve all TypeScript compilation errors across projects (#140)
* fix(typescript): resolve all TypeScript compilation errors across projects Fixed TypeScript compilation errors in three main projects: **rules-compiler-typescript:** - Added .js extensions to all relative imports (required for ES modules with NodeNext) - Fixed property access on index signatures (using bracket notation) - Fixed undefined type handling (added null checks and proper type guards) - Fixed environment variable access (process.env properties) **adguard-api-typescript:** - Added .js extensions to 45+ TypeScript files - Fixed type-only re-exports (using 'export type' syntax) - Fixed implicit any types in configuration helper - Corrected class inheritance and method accessibility **linear:** - Fixed property access on index signatures (bracket notation for config and env vars) - Added null safety checks for regex matches and optional properties - Used optional chaining and nullish coalescing operators - Removed unused imports - Added @ts-nocheck to mod.ts (Deno-specific file) All projects now compile successfully with npx tsc --noEmit. Only non-critical strict mode warnings remain in adguard-api-typescript. Fixes #139 * refactor: address PR review feedback while preserving strict TypeScript requirements (#141) * Initial plan * Address PR review feedback: improve type safety and code quality - logger.ts: Kept bracket notation and type guards (required by strict tsconfig) - configuration.ts: Removed redundant type annotations - cli.ts: Simplified error message formatting - linear-client.ts: Added proper null checks for strict mode - parser.ts: Added necessary type guards for strict mode - mod.ts: Properly typed Deno globals and used bracket notation Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
1 parent 2a83166 commit def301c

54 files changed

Lines changed: 1099 additions & 301 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/adguard-api-typescript/package-lock.json‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/adguard-api-typescript/src/api/account.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* Account API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
7-
import { AccountLimits } from '../models';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
7+
import { AccountLimits } from '../models/index.js';
88

99
/** Account API endpoints */
1010
export class AccountApi extends BaseApi {

‎src/adguard-api-typescript/src/api/auth.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
* Authentication API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
77
import {
88
AccessTokenCredentials,
99
AccessTokenResponse,
10-
} from '../models';
10+
} from '../models/index.js';
1111

1212
/** Authentication API endpoints */
1313
export class AuthApi extends BaseApi {

‎src/adguard-api-typescript/src/api/base.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ import {
99
createRetryableClient,
1010
Logger,
1111
silentLogger,
12-
} from '../helpers/configuration';
12+
} from '../helpers/configuration.js';
1313
import {
1414
ApiError,
1515
ValidationError,
1616
EntityNotFoundError,
1717
RateLimitError,
1818
AuthenticationError,
19-
} from '../errors';
20-
import { ErrorResponse } from '../models';
19+
} from '../errors/index.js';
20+
import { ErrorResponse } from '../models/index.js';
2121

2222
/** Base API client */
2323
export abstract class BaseApi {

‎src/adguard-api-typescript/src/api/dedicated-ips.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* Dedicated IP Addresses API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
7-
import { DedicatedIPv4Address } from '../models';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
7+
import { DedicatedIPv4Address } from '../models/index.js';
88

99
/** Dedicated IP Addresses API endpoints */
1010
export class DedicatedIpApi extends BaseApi {

‎src/adguard-api-typescript/src/api/devices.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
* Devices API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
77
import {
88
Device,
99
DeviceCreate,
1010
DeviceUpdate,
1111
DeviceSettingsUpdate,
1212
DedicatedIps,
1313
LinkDedicatedIPv4,
14-
} from '../models';
14+
} from '../models/index.js';
1515

1616
/** Devices API endpoints */
1717
export class DevicesApi extends BaseApi {

‎src/adguard-api-typescript/src/api/dns-servers.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
* DNS Servers API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
77
import {
88
DNSServer,
99
DNSServerCreate,
1010
DNSServerUpdate,
1111
DNSServerSettingsUpdate,
12-
} from '../models';
12+
} from '../models/index.js';
1313

1414
/** DNS Servers API endpoints */
1515
export class DnsServersApi extends BaseApi {

‎src/adguard-api-typescript/src/api/filter-lists.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* Filter Lists API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
7-
import { FilterList } from '../models';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
7+
import { FilterList } from '../models/index.js';
88

99
/** Filter Lists API endpoints */
1010
export class FilterListsApi extends BaseApi {

‎src/adguard-api-typescript/src/api/index.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
* AdGuard DNS API Clients
33
*/
44

5-
export * from './base';
6-
export * from './account';
7-
export * from './auth';
8-
export * from './devices';
9-
export * from './dns-servers';
10-
export * from './statistics';
11-
export * from './query-log';
12-
export * from './filter-lists';
13-
export * from './web-services';
14-
export * from './dedicated-ips';
5+
export * from './base.js';
6+
export * from './account.js';
7+
export * from './auth.js';
8+
export * from './devices.js';
9+
export * from './dns-servers.js';
10+
export * from './statistics.js';
11+
export * from './query-log.js';
12+
export * from './filter-lists.js';
13+
export * from './web-services.js';
14+
export * from './dedicated-ips.js';

‎src/adguard-api-typescript/src/api/query-log.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* Query Log API client
33
*/
44

5-
import { BaseApi } from './base';
6-
import { ApiConfiguration } from '../helpers/configuration';
7-
import { QueryLogResponse, QueryLogParams } from '../models';
5+
import { BaseApi } from './base.js';
6+
import { ApiConfiguration } from '../helpers/configuration.js';
7+
import { QueryLogResponse, QueryLogParams } from '../models/index.js';
88

99
/** Query Log API endpoints */
1010
export class QueryLogApi extends BaseApi {

0 commit comments

Comments
 (0)