Test content type#26
Open
pezholio wants to merge 35 commits into
Open
Conversation
I updated the URL of the blog post by Anthony Eden
Update README.md
Cucumber project is now hosted at https://github.com/cucumber/cucumber
Fix link to Cucumber
update rspec should syntax to v3 expect syntax
Fix cucumber feature title
This removes a deprivation warning that makes the running of tests look messy. And we want our cucumber warnings to run slick and professionally.
This also requires some updates on the tests, to remove deprecations and clean up the cucumber results.
Update Cucumber and Rspec
Update to the latest classes
Highlight Ruby and Gherkin syntax in README.md.
basically just a typo. usage of wrong variable made assertion fail always.
fix "the JSON response should be"
minitest assertions take the expected value as first, the actual value as second argument.
add line feeds every few characters. see https://ruby-doc.org/stdlib-2.2.0/libdoc/base64/rdoc/Base64.html#method-i-strict_encode64 ::strict_encode64 also uses the same #pack logic as rack-test does inside its #basic_authorize method. see https://github.com/rack-test/rack-test/blob/72fc72dc15bfd33f45bc13cd134fb5e2c04dbe1e/lib/rack/test.rb#L166 more: https://glaucocustodio.github.io/2014/09/27/a-reminder-about-base64encode64-in-ruby/
glaszig
reviewed
Apr 19, 2018
| Then the response status should be "200" | ||
|
|
||
| Scenario: Test response content type | ||
| And I perform the following step: |
fix assertion argument order
test against ruby 2.5 and ruby-head as well
The step is implemented as: `/^the XML response should have "([^"]*)" with the text "([^"]*)"$/`
Fixed a wrong example
…n-Front/cucumber-api-steps into feature-test-content-type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We thought this would be useful. Not sure how the tests for the the features are working though. Could you give us any pointers?