Fix issue when file names contain invalid characters#45
Open
zorone wants to merge 5 commits into
Open
Conversation
…sync no longer exit if error occurred while transfering files.
Author
|
@jb2170 Could you review my code, please? It's my first time I commit full work to an open source project. I'm scared I would mess up something. |
Prevent bug when user use BetterADBSync on POSIX system, on pull direction, and destination argument also contains colon at the 2nd character. A.K.A. adbsync pull /sdcard/Documents/0:2024-07-30.log 0:2024-07-30.log
Owner
|
I'll have a look at this soon thanks! I'm a bit busy right now, but this project isn't orphaned. (>19th August) |
Author
|
Sure! |
jpstotz
reviewed
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem mostly occur when pulling file from Android to Windows.
I have to implement it in various spots.
I also add --no-del option, which will prevent from removing files. I find it useful if I want to transferring to just one side. I implement it in various locations too.
Lastly, I also tweak logging_fatal() a bit since it prevents program from running further when there are any fatal error occurs. In my opinion, it feels really bad when program stops while it could still proceed. Like when there are some bad file names. It will halt the works although you could just skip those bad ones.
I have put TODO and FIXME all over the places, you could remove it if you want.