Skip to content

fix(files/rinkhals/start): fix ash's glob handling (/root rw)#368

Closed
milkpirate wants to merge 4 commits into
jbatonnet:masterfrom
milkpirate:fix/start-root-rw-overlay
Closed

fix(files/rinkhals/start): fix ash's glob handling (/root rw)#368
milkpirate wants to merge 4 commits into
jbatonnet:masterfrom
milkpirate:fix/start-root-rw-overlay

Conversation

@milkpirate
Copy link
Copy Markdown
Contributor

Bug

After starting Rinkhals the /root does not become writable, it just a * symlink with a dubious destination:

root@Rockchip:/root# ls -la
lrwxrwxrwx    1 root     root            29 * -> /tmp/rinkhals/original/root/*
drwxr-xr-x   23 root     root           355 ..
drwxr-xr-x    2 root     root            80 .

Explanation / Fix

See: https://chatgpt.com/s/t_6959a50f7d588191a516859cfc444c24

@milkpirate milkpirate marked this pull request as draft January 3, 2026 23:32
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the fix/start-root-rw-overlay branch from c15f2e9 to 4cfea39 Compare January 4, 2026 14:24
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the fix/start-root-rw-overlay branch from 6a4d20c to b5e0470 Compare January 6, 2026 00:47
Comment thread files/3-rinkhals/tools.sh
Comment on lines +6 to +7
export ROOT_HOME=/useremain/home/root

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbatonnet names/location ok?

Comment thread files/3-rinkhals/start.sh
@@ -212,6 +212,10 @@ fi
################
log "> Preparing mounts..."
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbatonnet right location?

@milkpirate milkpirate marked this pull request as ready for review January 6, 2026 00:56
@martinbogo
Copy link
Copy Markdown
Collaborator

Thanks for this contribution. The Rinkhals project has moved to a new home at https://github.com/rinkhals-community/Rinkhals and this repository is no longer maintained.

We can no longer merge PRs here. If your change is still relevant, please re-open it against the new repository, and make sure it targets the develop branch (not master/main), which is where active development happens.

Apologies for the inconvenience, and thank you for helping improve Rinkhals. Closing this PR here.

@martinbogo martinbogo closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants