Adds support for fetching cached images from an HTTP(S) source#8
Open
brandonhudson wants to merge 1 commit into
Open
Adds support for fetching cached images from an HTTP(S) source#8brandonhudson wants to merge 1 commit into
brandonhudson wants to merge 1 commit into
Conversation
bolbosenco
reviewed
Nov 18, 2019
|
|
||
| let buffer = null; | ||
|
|
||
| # If the url is an HTTP url, get the image from the external source |
There was a problem hiding this comment.
This is not a valid js comment. Try // or /* .. */
Sliver2022
approved these changes
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for fetching cached images from an external source (like AWS S3) that provide the cached image via a url. The current implementation fails with a 500 error because the image is not located on the filesystem.
fs.readFile...only supports fetching files located on the filesystem (reference).