Skip to content

Initial version of Dockerfile#56

Open
pmuir wants to merge 1 commit into
jboss-developer:2.6.0.Finalfrom
pmuir:dockerfiles
Open

Initial version of Dockerfile#56
pmuir wants to merge 1 commit into
jboss-developer:2.6.0.Finalfrom
pmuir:dockerfiles

Conversation

@pmuir

@pmuir pmuir commented Nov 9, 2014

Copy link
Copy Markdown

No description provided.

@pmuir

pmuir commented Nov 9, 2014

Copy link
Copy Markdown
Author

DO NOT MERGE

@ipbabble

Copy link
Copy Markdown

Would it be beneficial to combine some of the "RUN" cmds into a script that is added to the image? That way you can have one RUN layer and not so many.

@pmuir

pmuir commented Dec 10, 2014

Copy link
Copy Markdown
Author

@ipbabble what is best practice with Docker? :-)

@ipbabble

Copy link
Copy Markdown

I don't think it's fully decided yet. One could and would argue that having it in the Dockerfile is better because of transparency. i.e. the way you do it is correct. But because of the layering and the inability to squash layers then it becomes way too many layers for your image. You might also wish to pull some stuff out of the script if you think that you don't want certain steps run over and over again on build.

So maybe I've answered my own question ;-) i.e. it's perhaps not beneficial during dev. but beneficial when you've figured out what layers you are ok with as you move out of dev.

@pmuir

pmuir commented Dec 10, 2014

Copy link
Copy Markdown
Author

That's probably a great point to add to the tutorial, when we document this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants