Skip to content

Multi key support#238

Open
techanon wants to merge 13 commits into
jbroadway:masterfrom
techanon:multi-key-support
Open

Multi key support#238
techanon wants to merge 13 commits into
jbroadway:masterfrom
techanon:multi-key-support

Conversation

@techanon
Copy link
Copy Markdown
Contributor

Added methods: _key_type
Updated methods: __construct, get, put, remove, field
TODO methods: __call, next

Comment thread lib/Model.php Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $this should be $q here and on 536.

@techanon
Copy link
Copy Markdown
Contributor Author

I think both of those comments might be related (first one causing the second). Can you run those tests again with that model fix I pushed?

@jbroadway
Copy link
Copy Markdown
Owner

Still getting the exact same results. Do you have PHPUnit, and can you try running the tests via phpunit.phar tests/ModelTest.php? I'm also getting an error in the ExtendedModel test too:

$ phpunit.phar tests/ExtendedModelTest.php 
PHPUnit 4.4.0 by Sebastian Bergmann.

Configuration read from /Users/lux/projects/elefant/www/phpunit.xml.dist

FSSSS

Time: 32 ms, Memory: 3.50Mb

There was 1 failure:

1) ExtendedModelTest::test_create
Failed asserting that null matches expected 1.

/Users/lux/projects/elefant/www/tests/ExtendedModelTest.php:52

FAILURES!                                        
Tests: 1, Assertions: 4, Failures: 1, Skipped: 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants