Skip to content

Commit d2eb22e

Browse files
Fix exception tests to use synchronous Throw pattern
Changed async exception tests to use synchronous pattern as requested: - Removed async keyword from test method signatures - Changed await ThrowAsync pattern to synchronous act.Should().Throw() - Replaced await calls with direct object instantiation where needed - Fixed duplicate variable names in tests with multiple assertions Co-authored-by: JohnCampionJr <1094820+JohnCampionJr@users.noreply.github.com>
1 parent b082180 commit d2eb22e

19 files changed

Lines changed: 123 additions & 98 deletions

File tree

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,20 +67,22 @@ await store.AddClaimsAsync(user,
6767
}
6868

6969
[Fact]
70-
public async Task ThrowsExceptionWithNullArguments()
70+
public Task ThrowsExceptionWithNullArguments()
7171
{
7272
var context = new TestContext(GetConnection());
7373
var store = new MongoUserOnlyStore<TestUser>(context);
74-
var user = await store.FindByIdAsync("1000");
74+
var user = new TestUser();
7575

76-
await (async () =>
76+
var act = () =>
7777
{
78-
await store.AddClaimsAsync(null, new[] { new Claim("type", "value") });
79-
}).Should().ThrowAsync<ArgumentNullException>();
80-
await (async () =>
78+
var _ = store.AddClaimsAsync(null, new[] { new Claim("type", "value") });
79+
};
80+
act.Should().Throw<ArgumentNullException>();
81+
var act1 = () =>
8182
{
82-
await store.AddClaimsAsync(user, null);
83-
}).Should().ThrowAsync<ArgumentNullException>();
83+
var _ = store.AddClaimsAsync(user, null);
84+
};
85+
act1.Should().Throw<ArgumentNullException>();
8486
}
8587

8688
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,22 @@ public async Task SavesData()
5858
}
5959

6060
[Fact]
61-
public async Task ThrowsExceptionWithNullArguments()
61+
public Task ThrowsExceptionWithNullArguments()
6262
{
6363
var context = new TestContext(GetConnection());
6464
var store = new MongoUserOnlyStore<TestUser>(context);
65-
var user = await store.FindByIdAsync("1000");
65+
var user = new TestUser();
6666

67-
await (async () =>
67+
var act = () =>
6868
{
69-
await store.AddLoginAsync(null, new UserLoginInfo("", "", ""));
70-
}).Should().ThrowAsync<ArgumentNullException>();
71-
await (async () =>
69+
var _ = store.AddLoginAsync(null, new UserLoginInfo("", "", ""));
70+
};
71+
act.Should().Throw<ArgumentNullException>();
72+
var act1 = () =>
7273
{
73-
await store.AddLoginAsync(user, null);
74-
}).Should().ThrowAsync<ArgumentNullException>();
74+
var _ = store.AddLoginAsync(user, null);
75+
};
76+
act1.Should().Throw<ArgumentNullException>();
7577
}
7678

7779
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,16 @@ public async Task CreatesDataWithIntId()
7878
}
7979

8080
[Fact]
81-
public async Task ThrowsExceptionWithNull()
81+
public Task ThrowsExceptionWithNull()
8282
{
8383
var context = new TestContext(GetConnection());
8484
var store = new MongoUserOnlyStore<TestUser>(context);
8585

86-
await (async () =>
86+
var act = () =>
8787
{
88-
await store.CreateAsync(null);
89-
}).Should().ThrowAsync<ArgumentNullException>();
88+
var _ = store.CreateAsync(null);
89+
};
90+
act.Should().Throw<ArgumentNullException>();
9091
}
9192

9293
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,16 @@ public async Task ReturnsSuccessWithValidUser()
5151
}
5252

5353
[Fact]
54-
public async Task ThrowsExceptionWithNull()
54+
public Task ThrowsExceptionWithNull()
5555
{
5656
var context = new TestContext(GetConnection());
5757
var store = new MongoUserOnlyStore<TestUser>(context);
5858

59-
await (async () =>
59+
var act = () =>
6060
{
61-
await store.DeleteAsync(null);
62-
}).Should().ThrowAsync<ArgumentNullException>();
61+
var _ = store.DeleteAsync(null);
62+
};
63+
act.Should().Throw<ArgumentNullException>();
6364
}
6465

6566
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,16 @@ public async Task ReturnsNullWithInvalidIntId()
7777
}
7878

7979
[Fact]
80-
public async Task ThrowsExceptionWithNull()
80+
public Task ThrowsExceptionWithNull()
8181
{
8282
var context = new TestContext(GetConnection());
8383
var store = new MongoUserOnlyStore<TestUser>(context);
8484

85-
await (async () =>
85+
var act = () =>
8686
{
87-
await store.FindByIdAsync(null);
88-
}).Should().ThrowAsync<ArgumentNullException>();
87+
var _ = store.FindByIdAsync(null);
88+
};
89+
act.Should().Throw<ArgumentNullException>();
8990
}
9091

9192
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,16 @@ public async Task ReturnsNullWithInvalidUserName()
6565
}
6666

6767
[Fact]
68-
public async Task ThrowsExceptionWithNull()
68+
public Task ThrowsExceptionWithNull()
6969
{
7070
var context = new TestContext(GetConnection());
7171
var store = new MongoUserOnlyStore<TestUser>(context);
7272

73-
await (async () =>
73+
var act = () =>
7474
{
75-
await store.FindByNameAsync(null);
76-
}).Should().ThrowAsync<ArgumentNullException>();
75+
var _ = store.FindByNameAsync(null);
76+
};
77+
act.Should().Throw<ArgumentNullException>();
7778
}
7879

7980
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,16 @@ public async Task RetrievesClaimsFromUser()
4747
}
4848

4949
[Fact]
50-
public async Task ThrowsExceptionWithNullArguments()
50+
public Task ThrowsExceptionWithNullArguments()
5151
{
5252
var context = new TestContext(GetConnection());
5353
var store = new MongoUserOnlyStore<TestUser>(context);
5454

55-
await (async () =>
55+
var act = () =>
5656
{
57-
await store.GetClaimsAsync(null);
58-
}).Should().ThrowAsync<ArgumentNullException>();
57+
var _ = store.GetClaimsAsync(null);
58+
};
59+
act.Should().Throw<ArgumentNullException>();
5960
}
6061

6162
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,16 @@ public async Task RetrieveLoginsFromUser()
4343
}
4444

4545
[Fact]
46-
public async Task ThrowsExceptionWithNullArguments()
46+
public Task ThrowsExceptionWithNullArguments()
4747
{
4848
var context = new TestContext(GetConnection());
4949
var store = new MongoUserOnlyStore<TestUser>(context);
5050

51-
await (async () =>
51+
var act = () =>
5252
{
53-
await store.GetLoginsAsync(null);
54-
}).Should().ThrowAsync<ArgumentNullException>();
53+
var _ = store.GetLoginsAsync(null);
54+
};
55+
act.Should().Throw<ArgumentNullException>();
5556
}
5657

5758
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,16 @@ public async Task RetrieveLoginsFromUser()
4444
}
4545

4646
[Fact]
47-
public async Task ThrowsExceptionWithNullArguments()
47+
public Task ThrowsExceptionWithNullArguments()
4848
{
4949
var context = new TestContext(GetConnection());
5050
var store = new MongoUserOnlyStore<TestUser>(context);
5151

52-
await (async () =>
52+
var act = () =>
5353
{
54-
await store.GetTokenAsync(null, "", "", default);
55-
}).Should().ThrowAsync<ArgumentNullException>();
54+
var _ = store.GetTokenAsync(null, "", "", default);
55+
};
56+
act.Should().Throw<ArgumentNullException>();
5657
}
5758

5859
}

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,16 @@ public async Task RetrieveUsersForClaim()
6666
}
6767

6868
[Fact]
69-
public async Task ThrowsExceptionWithNullArguments()
69+
public Task ThrowsExceptionWithNullArguments()
7070
{
7171
var context = new TestContext(GetConnection());
7272
var store = new MongoUserOnlyStore<TestUser>(context);
7373

74-
await (async () =>
74+
var act = () =>
7575
{
76-
await store.GetClaimsAsync(null);
77-
}).Should().ThrowAsync<ArgumentNullException>();
76+
var _ = store.GetClaimsAsync(null);
77+
};
78+
act.Should().Throw<ArgumentNullException>();
7879
}
7980

8081
}

0 commit comments

Comments
 (0)