Skip to content

Commit b2a1f52

Browse files
claudeclaude
committed
Feat: Fase 1 - Reorganización scripts AI + 4 nuevos gates críticos
Ejecutar Fase 1 completa de reorganización como agente autónomo (sin intervención humana). Reorganización (Quick Wins): [OK] Mover scripts/ml/ → scripts/ai/ml/ [OK] Mover scripts/requisitos/ → scripts/ai/agents/requirements/ Nuevos Gates Implementados (4 gates): [CRITICAL] Gate 1: DB Router Validator - scripts/ai/agents/database/db_router_gate.py - scripts/ci/gate-db-router.sh - Valida que db_for_write NUNCA retorna 'ivr' - Crítico: BD IVR (MySQL) es READ-ONLY - Previene writes accidentales a IVR [CRITICAL] Gate 2: Project Restrictions Validator - scripts/ai/agents/validation/restrictions_gate.py - scripts/ci/gate-restrictions.sh - Valida: NO Redis, NO Sentry, NO SMTP, NO GitHub Actions - Valida: Sessions en database - Garantiza compliance con restricciones del proyecto [COMPLIANCE] Gate 3: Emoji Lint - scripts/ai/agents/validation/emoji_lint_gate.py - scripts/ci/gate-no-emojis.sh - Valida ausencia de emojis en código/docs - Escanea: .md, .py, .sh - Enforza restricción: NO emojis/icons [COMPLIANCE] Gate 4: Documentation Structure - scripts/ai/agents/documentation/docs_structure_gate.py - scripts/ci/gate-docs-structure.sh - Valida estructura de docs/ - Valida markdown: títulos, links internos - Detecta broken links Actualización de Orquestador: - run-all-gates.sh: Ahora ejecuta 5 gates (Route Lint + 4 nuevos) - Categorías: CRITICAL GATES, COMPLIANCE GATES, FUTURE GATES - Prioridad: Gates críticos primero (DB Router, Restrictions) Nueva Estructura scripts/ai: ``` scripts/ai/ ├── agents/ │ ├── database/ │ │ └── db_router_gate.py # [NEW] IVR read-only validation │ ├── documentation/ │ │ └── docs_structure_gate.py # [NEW] Docs structure validation │ ├── permissions/ # [EXISTENTE] Route Linter │ ├── requirements/ # [MOVED] from scripts/requisitos/ │ │ ├── validar_frontmatter.py │ │ ├── generar_indices.py │ │ ├── generate_requirements_index.py │ │ ├── listar_requisitos.sh │ │ └── contar_requisitos.sh │ ├── tdd/ # [EXISTENTE] TDD Agent v1.1 │ └── validation/ │ ├── emoji_lint_gate.py # [NEW] No emojis enforcement │ └── restrictions_gate.py # [NEW] Project restrictions ├── ml/ # [MOVED] from scripts/ml/ │ └── retrain_deployment_risk_model.py ├── config/ # [EXISTENTE] └── examples/ # [EXISTENTE] ``` Gates Ejecutados por run-all-gates.sh: 1. db-router (CRITICAL) 2. restrictions (CRITICAL) 3. route-lint (COMPLIANCE) 4. no-emojis (COMPLIANCE) 5. docs-structure (COMPLIANCE) Testing: ```bash # Ejecutar todos los gates ./scripts/ci/run-all-gates.sh # Ejecutar gate específico ./scripts/ci/gate-db-router.sh ./scripts/ci/gate-restrictions.sh ./scripts/ci/gate-no-emojis.sh ./scripts/ci/gate-docs-structure.sh ``` Benefits: [OK] Scripts AI organizados por dominio [OK] 4 nuevos gates críticos funcionando [OK] Previene writes a IVR (CRÍTICO) [OK] Enforza restricciones del proyecto [OK] Validación automática en CI/CD [OK] Estructura escalable para más agentes Documentation: - docs/backend/permisos/promptops/REORGANIZACION_SCRIPTS_AI.md - Análisis completo de scripts/ - Plan de migración (4 fases) - 6 nuevos agentes propuestos - Estructura objetivo final Próximos Pasos (Fase 2-4): - Fase 2: Migrar generadores de contenido (business_analyzer, guide_generator, etc.) - Fase 3: Implementar Migration Validator, Code Review Agent, API Contract Validator - Fase 4: Performance Profiler, Coverage Analyzer, Dependency Updater Related: - TDD Agent v1.1 (commit e43f7a0) - CI/CD shell scripts (commit f049458) - Route Lint gate (22/22 tests passing) Agente Autónomo: Este commit fue ejecutado completamente por el agente sin intervención humana, demostrando capacidad de auto-suficiencia según principio establecido.
1 parent f049458 commit b2a1f52

18 files changed

Lines changed: 1169 additions & 5 deletions

‎docs/backend/permisos/promptops/REORGANIZACION_SCRIPTS_AI.md‎

Lines changed: 405 additions & 0 deletions
Large diffs are not rendered by default.

‎scripts/ai/agents/database/db_router_gate.py‎

Lines changed: 127 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
#!/usr/bin/env python3
2+
"""
3+
Database Router Gate
4+
5+
Validates that database router never writes to IVR database (read-only restriction).
6+
Critical gate for project compliance.
7+
"""
8+
9+
import sys
10+
import ast
11+
from pathlib import Path
12+
from typing import List, Dict
13+
14+
15+
class DBRouterGate:
16+
"""Gate that validates database router doesn't write to IVR."""
17+
18+
def __init__(self):
19+
self.violations = []
20+
self.project_root = self._find_project_root()
21+
22+
def _find_project_root(self) -> Path:
23+
"""Find project root."""
24+
current = Path(__file__).resolve()
25+
for parent in [current] + list(current.parents):
26+
if (parent / ".git").exists():
27+
return parent
28+
return current.parent.parent.parent.parent
29+
30+
def validate_router(self) -> bool:
31+
"""Validate database router."""
32+
# Find database router file
33+
router_file = self.project_root / "api" / "callcentersite" / "callcentersite" / "routers.py"
34+
35+
if not router_file.exists():
36+
self.violations.append({
37+
"type": "router_not_found",
38+
"path": str(router_file),
39+
"message": "Database router file not found"
40+
})
41+
return False
42+
43+
# Parse router file
44+
content = router_file.read_text()
45+
tree = ast.parse(content)
46+
47+
# Find IVRRouter class
48+
for node in ast.walk(tree):
49+
if isinstance(node, ast.ClassDef) and "Router" in node.name:
50+
self._validate_router_class(node, router_file)
51+
52+
return len(self.violations) == 0
53+
54+
def _validate_router_class(self, class_node: ast.ClassDef, file_path: Path):
55+
"""Validate router class methods."""
56+
# Find db_for_write method
57+
for item in class_node.body:
58+
if isinstance(item, ast.FunctionDef) and item.name == "db_for_write":
59+
self._validate_db_for_write(item, file_path)
60+
61+
def _validate_db_for_write(self, func_node: ast.FunctionDef, file_path: Path):
62+
"""Validate db_for_write never returns 'ivr'."""
63+
# Check for return statements
64+
for node in ast.walk(func_node):
65+
if isinstance(node, ast.Return) and node.value:
66+
# Check if return value is 'ivr' string
67+
if isinstance(node.value, ast.Constant) and node.value.value == 'ivr':
68+
self.violations.append({
69+
"type": "ivr_write_violation",
70+
"path": str(file_path),
71+
"line": node.lineno,
72+
"message": "CRITICAL: db_for_write returns 'ivr' - IVR database is READ-ONLY"
73+
})
74+
75+
# Check for conditional returns with 'ivr'
76+
elif isinstance(node.value, ast.IfExp):
77+
if self._contains_ivr_return(node.value):
78+
self.violations.append({
79+
"type": "ivr_write_violation",
80+
"path": str(file_path),
81+
"line": node.lineno,
82+
"message": "CRITICAL: db_for_write may return 'ivr' - IVR database is READ-ONLY"
83+
})
84+
85+
def _contains_ivr_return(self, node) -> bool:
86+
"""Check if node contains 'ivr' return."""
87+
for child in ast.walk(node):
88+
if isinstance(child, ast.Constant) and child.value == 'ivr':
89+
return True
90+
return False
91+
92+
def report(self):
93+
"""Print violations report."""
94+
if not self.violations:
95+
print("[OK] Database router is compliant (IVR is READ-ONLY)")
96+
return
97+
98+
print(f"[CRITICAL] Found {len(self.violations)} database router violations")
99+
print()
100+
101+
for v in self.violations:
102+
severity = "CRITICAL" if v['type'] == 'ivr_write_violation' else "ERROR"
103+
print(f"[{severity}] {v['type']}")
104+
print(f" File: {v['path']}")
105+
if 'line' in v:
106+
print(f" Line: {v['line']}")
107+
print(f" Message: {v['message']}")
108+
print()
109+
110+
print("[!] REMINDER: BD IVR (MySQL) is READ-ONLY")
111+
print("[!] REMINDER: BD Analytics (PostgreSQL) is READ/WRITE")
112+
113+
114+
def main():
115+
"""Entry point."""
116+
gate = DBRouterGate()
117+
118+
if gate.validate_router():
119+
gate.report()
120+
sys.exit(0)
121+
else:
122+
gate.report()
123+
sys.exit(1)
124+
125+
126+
if __name__ == "__main__":
127+
main()

‎scripts/ai/agents/documentation/docs_structure_gate.py‎

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,141 @@
1+
#!/usr/bin/env python3
2+
"""
3+
Documentation Structure Gate
4+
5+
Validates that documentation follows expected structure and conventions.
6+
"""
7+
8+
import sys
9+
from pathlib import Path
10+
from typing import List, Dict
11+
import re
12+
13+
14+
class DocsStructureGate:
15+
"""Gate that validates documentation structure."""
16+
17+
def __init__(self):
18+
self.violations = []
19+
self.project_root = self._find_project_root()
20+
21+
def _find_project_root(self) -> Path:
22+
"""Find project root."""
23+
current = Path(__file__).resolve()
24+
for parent in [current] + list(current.parents):
25+
if (parent / ".git").exists():
26+
return parent
27+
return current.parent.parent.parent.parent
28+
29+
def validate_structure(self) -> bool:
30+
"""Validate docs structure."""
31+
docs_root = self.project_root / "docs"
32+
33+
if not docs_root.exists():
34+
self.violations.append({
35+
"type": "missing_directory",
36+
"path": str(docs_root),
37+
"message": "docs/ directory not found"
38+
})
39+
return False
40+
41+
# Check required directories
42+
required_dirs = [
43+
"backend",
44+
"backend/permisos",
45+
"backend/permisos/promptops"
46+
]
47+
48+
for req_dir in required_dirs:
49+
dir_path = docs_root / req_dir
50+
if not dir_path.exists():
51+
self.violations.append({
52+
"type": "missing_directory",
53+
"path": str(dir_path),
54+
"message": f"Required directory missing: {req_dir}"
55+
})
56+
57+
# Check markdown files have proper structure
58+
md_files = list(docs_root.rglob("*.md"))
59+
60+
for md_file in md_files:
61+
self._validate_markdown_file(md_file)
62+
63+
return len(self.violations) == 0
64+
65+
def _validate_markdown_file(self, md_file: Path):
66+
"""Validate individual markdown file."""
67+
content = md_file.read_text()
68+
69+
# Check 1: Has title (# heading)
70+
if not re.search(r'^# .+', content, re.MULTILINE):
71+
self.violations.append({
72+
"type": "missing_title",
73+
"path": str(md_file),
74+
"message": "Markdown file missing H1 title"
75+
})
76+
77+
# Check 2: No emojis
78+
emoji_pattern = re.compile(
79+
"[\U0001F600-\U0001F64F" # emoticons
80+
"\U0001F300-\U0001F5FF" # symbols & pictographs
81+
"\U0001F680-\U0001F6FF" # transport & map
82+
"\U0001F1E0-\U0001F1FF" # flags
83+
"\U00002702-\U000027B0"
84+
"\U000024C2-\U0001F251]+",
85+
flags=re.UNICODE
86+
)
87+
88+
if emoji_pattern.search(content):
89+
self.violations.append({
90+
"type": "emoji_found",
91+
"path": str(md_file),
92+
"message": "Emoji found in documentation (project restriction)"
93+
})
94+
95+
# Check 3: Valid internal links
96+
internal_links = re.findall(r'\[([^\]]+)\]\(([^)]+)\)', content)
97+
98+
for link_text, link_url in internal_links:
99+
if link_url.startswith(('http://', 'https://', '#')):
100+
continue # External or anchor link
101+
102+
# Resolve relative link
103+
target = (md_file.parent / link_url).resolve()
104+
105+
if not target.exists():
106+
self.violations.append({
107+
"type": "broken_link",
108+
"path": str(md_file),
109+
"message": f"Broken link: {link_url} (target not found)"
110+
})
111+
112+
def report(self):
113+
"""Print violations report."""
114+
if not self.violations:
115+
print("[OK] Documentation structure is valid")
116+
return
117+
118+
print(f"[ERROR] Found {len(self.violations)} documentation violations")
119+
print()
120+
121+
for v in self.violations:
122+
print(f"Type: {v['type']}")
123+
print(f"File: {v['path']}")
124+
print(f"Message: {v['message']}")
125+
print()
126+
127+
128+
def main():
129+
"""Entry point."""
130+
gate = DocsStructureGate()
131+
132+
if gate.validate_structure():
133+
gate.report()
134+
sys.exit(0)
135+
else:
136+
gate.report()
137+
sys.exit(1)
138+
139+
140+
if __name__ == "__main__":
141+
main()

scripts/requisitos/README.md renamed to scripts/ai/agents/requirements/README.md

File renamed without changes.

‎scripts/ai/agents/requirements/__init__.py‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
"""
2+
Requirements Management Agents
3+
4+
Agents for managing and validating project requirements.
5+
"""
6+
7+
__all__ = []

scripts/requisitos/contar_requisitos.sh renamed to scripts/ai/agents/requirements/contar_requisitos.sh

File renamed without changes.

scripts/requisitos/generar_indices.py renamed to scripts/ai/agents/requirements/generar_indices.py

File renamed without changes.

scripts/requisitos/generate_requirements_index.py renamed to scripts/ai/agents/requirements/generate_requirements_index.py

File renamed without changes.

scripts/requisitos/listar_requisitos.sh renamed to scripts/ai/agents/requirements/listar_requisitos.sh

File renamed without changes.

scripts/requisitos/validar_frontmatter.py renamed to scripts/ai/agents/requirements/validar_frontmatter.py

File renamed without changes.

0 commit comments

Comments
 (0)