Debug API 500 errors and fix prompt length issues#187
Merged
2-Coatl merged 2 commits intoNov 14, 2025
Conversation
Move files to comply with ADR_010 (organization by domain): TESTS MOVED: - tests/ai/automation/* → scripts/coding/tests/ai/automation/ • All 6 test files (252 tests total) • All fixtures (9 files) • Follows existing pattern in scripts/coding/tests/ai/ REPORTS MOVED: - *_REPORT.md (root) → docs/devops/automatizacion/planificacion/ • SCHEMA_VALIDATOR_AGENT_IMPLEMENTATION_REPORT.md • INTEGRATION_READINESS_REPORT.md • MERGE_EXECUTION_REPORT.md RATIONALE: Per ADR_010, tests should follow code structure: - Code: scripts/coding/ai/automation/*.py - Tests: scripts/coding/tests/ai/automation/*.py (parallel structure) - NOT: tests/ in root (violates domain organization) Reports belong in docs/devops/ domain, not project root. IMPACT: - Zero code changes (pure file moves) - Imports already correct (scripts.coding.ai.automation) - Git preserves history (R = rename detected) - Structure now consistent with existing codebase Related: ADR_010, commit 4850495 (original implementation)
… domains Apply complete 5-level BABOK/ISO 29148 hierarchy uniformly to all domains (ai, backend, frontend, infraestructura) as defined in commit 9f7a392. STANDARDIZED STRUCTURE: docs/{domain}/requisitos/ ├── reglas_negocio/ (Nivel 1: Business Rules) ├── requerimientos_negocio/ (Nivel 2: Business Requirements) ├── requerimientos_usuario/ (Nivel 3: User Requirements) │ └── casos_uso/ ├── requerimientos_funcionales/ (Nivel 4: Functional Requirements) └── atributos_calidad/ (Nivel 5: Quality Attributes) CHANGES BY DOMAIN: AI: + Created requerimientos_negocio/ (Level 2) + Created requerimientos_funcionales/ (Level 4) + Added 2 READMEs BACKEND: - Removed legacy dirs: necesidades/, negocio/, no_funcionales/ + Moved files to requerimientos_negocio/ ~ Renamed funcionales/ → requerimientos_funcionales/ ~ Moved no_funcionales/* → atributos_calidad/ + Added 2 READMEs FRONTEND: - Removed no_funcionales/ + Created requerimientos_negocio/ (Level 2) ~ Renamed funcionales/ → requerimientos_funcionales/ ~ Moved no_funcionales/* → atributos_calidad/ + Added 2 READMEs INFRAESTRUCTURA: - Removed no_funcionales/ + Created requerimientos_negocio/ (Level 2) ~ Renamed funcionales/ → requerimientos_funcionales/ ~ Moved no_funcionales/* → atributos_calidad/ + Added 2 READMEs FILES AFFECTED: 57 - 8 new READMEs created - 40+ files renamed (git preserves history) - 3 legacy directories removed ALL READMEs REFERENCE: - docs/gobernanza/marco_integrado/marco_reglas_negocio.md - docs/gobernanza/marco_integrado/marco_casos_uso.md COMPLIANCE: - Follows ADR_010 (organization by domain) - Consistent with commit 9f7a392 structure definition - Enables uniform requirements management Related: #186, commit 9f7a392, ADR_010
2-Coatl
deleted the
claude/fix-api-500-errors-01DGQS3NaWHJLJWsTRPne9cS
branch
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive test suites for automation agents following a Test-Driven Development (TDD) approach. The changes introduce tests for five key agents (SchemaValidator, MetricsCollector, DevContainerValidator, ConstitutionValidator, and CoherenceAnalyzer), test fixtures, implementation reports, and business requirement documentation.
Key Changes
- Added 5 comprehensive test files for automation agents (~4,000 lines total)
- Created 9 test fixture files for validation scenarios
- Added SDLC documentation including implementation reports and integration guides
- Documented business requirements for backend functionality
- Reorganized requirements documentation structure
Reviewed Changes
Copilot reviewed 15 out of 76 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_schema_validator_agent.py | Comprehensive tests (23) for YAML/JSON schema validation following TDD |
| test_metrics_collector_agent.py | TDD tests for DORA metrics collection and analysis |
| test_devcontainer_validator_agent.py | Tests for DevContainer environment validation |
| test_constitution_validator_agent.py | Tests for code constitution rule enforcement |
| test_coherence_analyzer_agent.py | Tests for UI/API coherence analysis |
| test_ci_pipeline_orchestrator_agent.py | Tests for CI pipeline orchestration (1,188 lines) |
| fixtures/*.yaml, *.json | Test data fixtures for validation scenarios |
| SCHEMA_VALIDATOR_AGENT_IMPLEMENTATION_REPORT.md | Detailed implementation report documenting TDD process |
| MERGE_EXECUTION_REPORT.md | Merge strategy documentation |
| INTEGRATION_READINESS_REPORT.md | Integration preparation documentation |
| Backend requirements docs | Business requirements and functional specifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.