style: sonarqube security

Author: jd-apprentice

src/image/image-repository.ts

@@ -26,7 +26,7 @@ class ImageRepository {
 
     return Image.create({
       ...image,
-      tag: _idTag ?? image.tag,  // Use validated tag or fallback
+      tag: _idTag ?? image.tag, // Use validated tag or fallback
     });
   }
 

src/user/user-middleware.ts

@@ -53,12 +53,23 @@ const validateUser = async (
   next: NextFunction,
 ): Promise<MiddlewareUser> => {
   try {
-    const { username, password } = req.body as { username: string; password: string };
-    const [sanitizedUsername, sanitizedPassword] = [username.toString(), password.toString()];
+    const { username, password } = req.body as {
+      username: string;
+      password: string;
+    };
+    const [sanitizedUsername, sanitizedPassword] = [
+      username.toString(),
+      password.toString(),
+    ];
 
-    const user = await User.findOne({ $expr: { $eq: ['$username', sanitizedUsername] } });
+    const user = await User.findOne({
+      $expr: { $eq: ['$username', sanitizedUsername] },
+    });
 
-    if (user?.password && (await bcrypt.compare(sanitizedPassword, user.password))) {
+    if (
+      user?.password &&
+      (await bcrypt.compare(sanitizedPassword, user.password))
+    ) {
       return next();
     }
 
@@ -82,7 +93,9 @@ const isAdmin = async (
   const sanitizedUsername = username.toString();
 
   try {
-    const user = await User.findOne({ $expr: { $eq: ['$username', sanitizedUsername] } });
+    const user = await User.findOne({
+      $expr: { $eq: ['$username', sanitizedUsername] },
+    });
 
     if (user?.isAdmin) {
       return next();
@@ -108,10 +121,10 @@ const validateToken = async (
   try {
     const { authorization } = req.headers;
     const token = authorization?.replace('Bearer ', '');
+    if (!token) return res.status(401).json(boom.unauthorized());
     if (secret) {
-      if (!token) return res.json(boom.unauthorized());
       const decoded = jwt.verify(token, secret);
-      return decoded ? next() : res.json(boom.unauthorized());
+      return decoded ? next() : res.status(401).json(boom.unauthorized());
     }
   } catch (error) {
     return res.status(401).json(boom.unauthorized());

src/user/user-repository.ts

@@ -34,7 +34,7 @@ class UserRepository {
    */
   async findUser(id: string): Promise<IUser | null> {
     const sanitizedId = id.toString();
-    return User.findOne({ $expr: { $eq: ["$_id", sanitizedId] } })
+    return User.findOne({ $expr: { $eq: ['$_id', sanitizedId] } });
   }
 
   /**
@@ -43,7 +43,7 @@ class UserRepository {
    */
   async findUserByUsername(username: string): Promise<IUser | null> {
     const sanitizedUsername = username.toString();
-    return User.findOne({ $expr: { $eq: ["$username", sanitizedUsername] } });
+    return User.findOne({ $expr: { $eq: ['$username', sanitizedUsername] } });
   }
 
   /**