bugfix: fix the problem of incorrect kv cache data format when enabli…#1203
Closed
longhui-z wants to merge 0 commit intojd-opensource:mainfrom
Closed
bugfix: fix the problem of incorrect kv cache data format when enabli…#1203longhui-z wants to merge 0 commit intojd-opensource:mainfrom
longhui-z wants to merge 0 commit intojd-opensource:mainfrom
Conversation
longhui-z
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates model type checks to use prefix matching for "deepseek_v3" instead of exact equality. The review feedback suggests using rfind for a more idiomatic prefix check and recommends defining the model type string as a constant to comply with the project's naming conventions (Rule 18).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng prefix cache feature(for deepseek v3 model).