feat: improve cuda shared memory tensor handling.#1222
Merged
RobbieLeung merged 1 commit intojd-opensource:mainfrom Apr 14, 2026
Merged
feat: improve cuda shared memory tensor handling.#1222RobbieLeung merged 1 commit intojd-opensource:mainfrom
RobbieLeung merged 1 commit intojd-opensource:mainfrom
Conversation
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a structured serialization and deserialization mechanism for forward input data, utilizing a layout that separates metadata descriptors from a tensor arena to improve memory management and support CUDA zero-copy. The review feedback identifies several opportunities to better align with the project's style guide, specifically regarding naming conventions for struct members (using trailing underscores), preferring emplace_back for vector operations, and optimizing loops by hoisting conditionals or using function pointer casts instead of verbose lambdas.
RobbieLeung
force-pushed
the
feat/cuda_shm
branch
from
9df95bd to
48cb6ac
Compare
XuZhang99
approved these changes
Apr 14, 2026
JimHsiung
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.