bugfix: remove spurious backslash breaking output redirection in launch scripts.#1248
Conversation
There was a problem hiding this comment.
Code Review
This pull request cleans up shell command examples in the documentation by removing unnecessary backslashes before output redirection in docs/en/getting_started/launch_xllm.md. I have no feedback to provide as there were no review comments.
|
Hi! Just following up on this PR — it removes the spurious backslash that was breaking output redirection in the launch scripts. The automated review (Gemini) found no issues. Would appreciate a maintainer review when you get a chance. Thanks! |
|
Hi @kuishou68, we couldn't reproduce this issue in our all docker image. |
|
Thanks for checking. The issue I observed was on a bare Ubuntu 22.04 host running the launch scripts directly (not via Docker image). The backslash on line N breaks the shell redirection when the script is run with |
Currently, xllm only can run on docker images provided by us. |
Closes #1247
Problem
In
docs/en/getting_started/launch_xllm.md, all three platform launch scripts (NPU, NVIDIA GPU, MLU) contain a shell syntax error on the final argument line:The
\ >sequence causes the shell to interpret>as a literal escaped character rather than a redirection operator. As a result:Fix
Remove the spurious
\before>in all three script blocks (lines 46, 87, 123):Testing