fix issue with redirecting to intended links after tracking#258
Open
Khuthaily wants to merge 1 commit into
Open
fix issue with redirecting to intended links after tracking#258Khuthaily wants to merge 1 commit into
Khuthaily wants to merge 1 commit into
Conversation
The PR improves the getDomainsInContextAttribute() method by (1) extracting domains (including decoded URLs and subdomains) from the content (if the content is logged) and (2) allowing the developer to add their own list of domains in case they have chosen not to log the content.
bretto36
reviewed
Jul 2, 2025
| } else { | ||
| // If the content of the email is not logged in the sent_emails table, | ||
| // return an array of the domains you are tracking in your email. | ||
| $domains = []; |
Contributor
There was a problem hiding this comment.
So providing an empty array means it will never redirect to the correct url
the second part of this if is always true so it's always going to redirect to the missing links thing
if ( ! $tracker || empty($tracker->domains_in_context) || ! in_array($url_host, $tracker->domains_in_context) ){
return redirect(config('mail-tracker.redirect-missing-links-to') ?: '/');
}
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR improves the getDomainsInContextAttribute() method by (1) extracting domains (including decoded URLs and subdomains) from the content (if the content is logged) and (2) allowing the developer to add their own list of domains in case they have chosen not to log the content.