Skip to content

Commit 1aa8557

Browse files
committed
Actually use the new test fixture everywhere
1 parent 403895f commit 1aa8557

2 files changed

Lines changed: 14 additions & 10 deletions

File tree

binder/src/test/java/io/grpc/binder/internal/RobolectricBinderTransportTest.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ BinderClientTransportFactory.Builder newClientTransportFactoryBuilder() {
175175

176176
BinderClientTransportBuilder newClientTransportBuilder() {
177177
return new BinderClientTransportBuilder()
178-
.setClientTransportFactory(newClientTransportFactoryBuilder().buildClientTransportFactory())
178+
.setFactory(newClientTransportFactoryBuilder().buildClientTransportFactory())
179179
.setServerAddress(server.getListenSocketAddress());
180180
}
181181

@@ -187,7 +187,7 @@ protected ManagedClientTransport newClientTransport(InternalServer server) {
187187

188188
return newClientTransportBuilder()
189189
.setServerAddress(server.getListenSocketAddress())
190-
.setClientTransportOptions(options)
190+
.setOptions(options)
191191
.build();
192192
}
193193

@@ -213,7 +213,7 @@ public void clientAuthorizesServerUidsInOrder() throws Exception {
213213
SettableAsyncSecurityPolicy securityPolicy = new SettableAsyncSecurityPolicy();
214214
client =
215215
newClientTransportBuilder()
216-
.setClientTransportFactory(
216+
.setFactory(
217217
newClientTransportFactoryBuilder()
218218
.setSecurityPolicy(securityPolicy)
219219
.buildClientTransportFactory())
@@ -243,10 +243,15 @@ public void eagAttributeCanOverrideChannelPreAuthServerSetting() throws Exceptio
243243
options.setEagAttributes(
244244
Attributes.newBuilder().set(ApiConstants.PRE_AUTH_SERVER_OVERRIDE, true).build());
245245
client =
246-
newClientTransportFactoryBuilder()
247-
.setSecurityPolicy(securityPolicy)
248-
.buildClientTransportFactory()
249-
.newClientTransport(server.getListenSocketAddress(), options, null);
246+
newClientTransportBuilder()
247+
.setOptions(options)
248+
.setFactory(
249+
newClientTransportFactoryBuilder()
250+
.setPreAuthorizeServers(preAuthServersParam) // To be overridden.
251+
.setSecurityPolicy(securityPolicy)
252+
.buildClientTransportFactory()
253+
)
254+
.build();
250255
runIfNotNull(client.start(mockClientTransportListener));
251256

252257
AuthRequest preAuthRequest = securityPolicy.takeNextAuthRequest(TIMEOUT_MS, MILLISECONDS);

binder/src/testFixtures/java/io/grpc/binder/internal/BinderClientTransportBuilder.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,12 @@ public BinderClientTransportBuilder setChannelLogger(ChannelLogger channelLogger
4444
return this;
4545
}
4646

47-
public BinderClientTransportBuilder setClientTransportOptions(ClientTransportOptions options) {
47+
public BinderClientTransportBuilder setOptions(ClientTransportOptions options) {
4848
this.options = checkNotNull(options);
4949
return this;
5050
}
5151

52-
public BinderClientTransportBuilder setClientTransportFactory(
53-
BinderClientTransportFactory factory) {
52+
public BinderClientTransportBuilder setFactory(BinderClientTransportFactory factory) {
5453
this.factory = checkNotNull(factory);
5554
return this;
5655
}

0 commit comments

Comments
 (0)