Skip to content

Commit 25cb32f

Browse files
committed
binder: bazel build support (bzlmod mode only)
1 parent 94c6595 commit 25cb32f

6 files changed

Lines changed: 104 additions & 5 deletions

File tree

.bazelrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
build --cxxopt=-std=c++17 --host_cxxopt=-std=c++17
2+
3+
common:skip_android --deleted_packages=binder

.github/workflows/testing.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ jobs:
8080
strategy:
8181
matrix:
8282
bzlmod: [true, false]
83-
env:
84-
USE_BAZEL_VERSION: 8.7.0
8583

8684
steps:
8785
- uses: actions/checkout@v4
@@ -100,10 +98,10 @@ jobs:
10098
key: ${{ runner.os }}-bazel-${{ env.USE_BAZEL_VERSION }}-${{ hashFiles('WORKSPACE', 'repositories.bzl') }}
10199

102100
- name: Run bazel build
103-
run: bazelisk build //... --enable_bzlmod=${{ matrix.bzlmod }} --enable_workspace=${{ !matrix.bzlmod }}
101+
run: bazelisk build //... --config=skip_android --enable_bzlmod=${{ matrix.bzlmod }} --enable_workspace=${{ !matrix.bzlmod }}
104102

105103
- name: Run bazel test
106-
run: bazelisk test //... --enable_bzlmod=${{ matrix.bzlmod }} --enable_workspace=${{ !matrix.bzlmod }}
104+
run: bazelisk test //... --config=skip_android --enable_bzlmod=${{ matrix.bzlmod }} --enable_workspace=${{ !matrix.bzlmod }}
107105

108106
- name: Run example bazel build
109107
run: bazelisk build //... --enable_bzlmod=${{ matrix.bzlmod }} --enable_workspace=${{ !matrix.bzlmod }}

COMPILING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,5 +164,14 @@ To build the grpc-java library:
164164
$ bazelisk build //...
165165
```
166166

167+
Some parts of grpc-java depend on Android. Bazel can build these parts too but,
168+
for size, licensing and maintenance reasons, it requires a locally installed
169+
Android SDK. If you don't have the SDK and/or don't care about Android, use the
170+
`skip_android` configuration to skip building the Android parts:
171+
172+
```sh
173+
$ bazelisk build //... --config=skip_android
174+
```
175+
167176
You cannot run the tests from Bazel at this time.
168177

MODULE.bazel

Lines changed: 49 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,31 @@ IO_GRPC_GRPC_JAVA_ARTIFACTS = [
4646
]
4747
# GRPC_DEPS_END
4848

49+
ANDROID_ARTIFACTS = [
50+
"androidx.annotation:annotation:1.6.0",
51+
"androidx.annotation:annotation-jvm:1.6.0",
52+
"androidx.core:core:1.13.1",
53+
"androidx.lifecycle:lifecycle-common:2.6.2",
54+
]
55+
4956
bazel_dep(name = "abseil-cpp", version = "20250512.1")
5057
bazel_dep(name = "bazel_jar_jar", version = "0.1.11.bcr.1")
5158
bazel_dep(name = "bazel_skylib", version = "1.7.1")
5259
bazel_dep(name = "googleapis", version = "0.0.0-20240326-1c8d509c5", repo_name = "com_google_googleapis")
5360
bazel_dep(name = "grpc-proto", version = "0.0.0-20240627-ec30f58.bcr.1", repo_name = "io_grpc_grpc_proto")
5461
bazel_dep(name = "protobuf", version = "33.4", repo_name = "com_google_protobuf")
62+
bazel_dep(name = "rules_android", version = "0.7.2")
5563
bazel_dep(name = "rules_cc", version = "0.0.9")
5664
bazel_dep(name = "rules_java", version = "9.1.0")
5765
bazel_dep(name = "rules_jvm_external", version = "6.0")
5866

67+
android_sdk_repository_extension = use_extension(
68+
"@rules_android//rules/android_sdk_repository:rule.bzl",
69+
"android_sdk_repository_extension",
70+
)
71+
use_repo(android_sdk_repository_extension, "androidsdk")
72+
register_toolchains("@androidsdk//:sdk-toolchain", "@androidsdk//:all")
73+
5974
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
6075
maven.install(
6176
artifacts = IO_GRPC_GRPC_JAVA_ARTIFACTS,
@@ -64,7 +79,36 @@ maven.install(
6479
],
6580
strict_visibility = True,
6681
)
67-
use_repo(maven, "maven")
82+
83+
# We isolate Android-specific deps in this separate repo ('grpc_android_maven') instead of the one
84+
# above (having default name 'maven').
85+
#
86+
# Under bzlmod, rules_jvm_external merges all contributions to the same named repository (like the
87+
# default 'maven' repo) across the entire dependency graph. If we put Android dependencies there,
88+
# then *every* downstream consumer's merged 'maven' repository would include these Android
89+
# artifacts.
90+
#
91+
# Because merged repositories are resolved using only the root module's (the consumer's)
92+
# repository list, any consumer without 'maven.google.com' configured in their root module
93+
# would fail to resolve these artifacts, breaking their build even if they don't use Android.
94+
#
95+
# By using a distinct name ('grpc_android_maven'), we prevent merging. This repository is resolved
96+
# independently, allowing it to use grpc-java's own repository config (which includes
97+
# maven.google.com) without affecting downstream consumers' default 'maven' repo.
98+
maven.install(
99+
name = "grpc_android_maven",
100+
artifacts = ANDROID_ARTIFACTS,
101+
repositories = [
102+
"https://repo.maven.apache.org/maven2/",
103+
"https://maven.google.com", # for androidx.*
104+
],
105+
strict_visibility = True,
106+
# Enable Starlark Android rules in rules_jvm_external for Bazel 8+ compatibility.
107+
use_starlark_android_rules = True,
108+
# Explicitly set the label for aar_import since the default guess is incorrect under Bzlmod.
109+
aar_import_bzl_label = "@rules_android//rules:rules.bzl",
110+
)
111+
use_repo(maven, "maven", "grpc_android_maven")
68112

69113
maven.override(
70114
coordinates = "com.google.protobuf:protobuf-java",
@@ -158,3 +202,7 @@ maven.override(
158202
coordinates = "io.grpc:grpc-util",
159203
target = "@io_grpc_grpc_java//util",
160204
)
205+
maven.override(
206+
coordinates = "io.grpc:grpc-binder",
207+
target = "@io_grpc_grpc_java//binder",
208+
)

binder/BUILD.bazel

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
load("@rules_android//rules:rules.bzl", "android_library")
2+
load("@rules_jvm_external//:defs.bzl", "artifact")
3+
4+
licenses(["notice"])
5+
6+
android_library(
7+
name = "binder",
8+
srcs = glob([
9+
"src/main/java/**/*.java",
10+
]),
11+
manifest = "src/main/AndroidManifest.xml",
12+
custom_package = "io.grpc.binder",
13+
visibility = ["//visibility:public"],
14+
exports = ["@grpc_android_maven//:androidx_annotation_annotation"],
15+
deps = [
16+
"//api",
17+
"//core:internal",
18+
# Resolve android deps from the isolated grpc_android_maven repository.
19+
"@grpc_android_maven//:androidx_annotation_annotation",
20+
"@grpc_android_maven//:androidx_annotation_annotation_jvm",
21+
"@grpc_android_maven//:androidx_core_core",
22+
"@grpc_android_maven//:androidx_lifecycle_lifecycle_common",
23+
artifact("com.google.code.findbugs:jsr305"),
24+
artifact("com.google.errorprone:error_prone_annotations"),
25+
artifact("com.google.guava:guava"),
26+
],
27+
)

buildscripts/kokoro/android.sh

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,21 @@ unzip -qd "${ANDROID_HOME}/cmdline-tools" cmdline.zip
2727
rm cmdline.zip
2828
mv "${ANDROID_HOME}/cmdline-tools/cmdline-tools" "${ANDROID_HOME}/cmdline-tools/latest"
2929
(yes || true) | "${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager" --licenses
30+
31+
# Bazel requires build-tools at least version 35.0.0 and, unlike gradle, can't
32+
# download it for itself. TODO(jdcormie): Keep this version in sync with AGP's
33+
# default and/or any `buildToolsVersion` gradle config.
34+
"${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager" --install "build-tools;35.0.1"
35+
3036
curl -Ls https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz | \
3137
tar xz -C /tmp
3238
export PATH=/tmp/cmake-3.26.3-linux-x86_64/bin:$PATH
39+
40+
# Install bazelisk to take care of installing the proper version(s) of bazel.
41+
mkdir /tmp/bazelisk
42+
curl -Ls -o /tmp/bazelisk/bazelisk https://github.com/bazelbuild/bazelisk/releases/download/v1.19.0/bazelisk-linux-amd64
43+
chmod +x /tmp/bazelisk/bazelisk
44+
export PATH=/tmp/bazelisk:$PATH
3345

3446
# Proto deps
3547
buildscripts/make_dependencies.sh
@@ -44,6 +56,9 @@ sudo update-java-alternatives --set java-1.11.0-openjdk-amd64
4456
# Unset any existing JAVA_HOME env var to stop Gradle from using it
4557
unset JAVA_HOME
4658

59+
# TODO(jdcormie): Use the same SDK version as build.gradle's compileSdkVersion.
60+
bazelisk build --android_sdk=@androidsdk//:sdk-34 //binder:binder
61+
4762
GRADLE_FLAGS="-Pandroid.useAndroidX=true"
4863

4964
./gradlew \

0 commit comments

Comments
 (0)