Skip to content

Commit 2b81085

Browse files
committed
Add javadoc. Make private
1 parent 5bbe4a7 commit 2b81085

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

core/src/testFixtures/java/io/grpc/internal/MockServerListener.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@
2424
import java.util.concurrent.LinkedBlockingQueue;
2525
import java.util.concurrent.TimeUnit;
2626

27+
/**
28+
* A {@link ServerListener} that helps you write blocking unit tests.
29+
*
30+
* <p>TODO: Rename, since this is not actually a mock:
31+
* https://testing.googleblog.com/2013/07/testing-on-toilet-know-your-test-doubles.html
32+
*/
2733
public class MockServerListener implements ServerListener {
2834
private final BlockingQueue<MockServerTransportListener> listeners = new LinkedBlockingQueue<>();
2935
private final SettableFuture<?> shutdown = SettableFuture.create();

core/src/testFixtures/java/io/grpc/internal/MockServerTransportListener.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,15 @@
2727
import java.util.concurrent.LinkedBlockingQueue;
2828
import java.util.concurrent.TimeUnit;
2929

30+
/**
31+
* A {@link ServerTransportListener} that helps you write blocking unit tests.
32+
*
33+
* <p>TODO: Rename, since this is not actually a mock:
34+
* https://testing.googleblog.com/2013/07/testing-on-toilet-know-your-test-doubles.html
35+
*/
3036
public class MockServerTransportListener implements ServerTransportListener {
3137
public final ServerTransport transport;
32-
public final BlockingQueue<StreamCreation> streams = new LinkedBlockingQueue<>();
38+
private final BlockingQueue<StreamCreation> streams = new LinkedBlockingQueue<>();
3339
private final SettableFuture<?> terminated = SettableFuture.create();
3440

3541
public MockServerTransportListener(ServerTransport transport) {

core/src/testFixtures/java/io/grpc/internal/ServerStreamListenerBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import java.util.concurrent.TimeUnit;
2929

3030
/**
31-
* A {@link ServerStreamListener} that helps you write unit tests.
31+
* A {@link ServerStreamListener} that helps you write blocking unit tests.
3232
*/
3333
public class ServerStreamListenerBase implements ServerStreamListener {
3434
public final BlockingQueue<InputStream> messageQueue = new LinkedBlockingQueue<>();

0 commit comments

Comments
 (0)