Skip to content

Commit bac0877

Browse files
committed
Don't commit to a roll out plan
1 parent 6658220 commit bac0877

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

binder/src/main/java/io/grpc/binder/BinderChannelBuilder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,9 @@ private BinderChannelBuilder(
176176
managedChannelImplBuilder =
177177
new ManagedChannelImplBuilder(
178178
directAddress, directAddress.getAuthority(), transportFactoryBuilder, null);
179-
// TODO(jdcormie): Rollout step 2: Pre-auth *all* addresses by default.
180-
preAuthorizeServers(false);
181179
} else {
182180
managedChannelImplBuilder =
183181
new ManagedChannelImplBuilder(target, transportFactoryBuilder, null);
184-
// TODO(jdcormie): Rollout step 1: Pre-auth NameResolver results by default.
185-
preAuthorizeServers(false);
186182
}
187183
idleTimeout(60, TimeUnit.SECONDS);
188184
}

binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public final class BinderClientTransportFactory implements ClientTransportFactor
5555
final InboundParcelablePolicy inboundParcelablePolicy;
5656
final OneWayBinderProxy.Decorator binderDecorator;
5757
final long readyTimeoutMillis;
58-
final boolean preAuthorizeServers;
58+
final boolean preAuthorizeServers; // TODO(jdcormie): Default to true.
5959

6060
ScheduledExecutorService executorService;
6161
Executor offloadExecutor;
@@ -220,7 +220,7 @@ public Builder setReadyTimeoutMillis(long readyTimeoutMillis) {
220220
return this;
221221
}
222222

223-
/** Whether to check server addresses against the SecurityPolicy before binding to them. */
223+
/** Whether to check server addresses against the SecurityPolicy *before* binding to them. */
224224
public Builder setPreAuthorizeServers(boolean preAuthorizeServers) {
225225
this.preAuthorizeServers = preAuthorizeServers;
226226
return this;

0 commit comments

Comments
 (0)