sdl3.targets: serialize SDL3 download with a mutex

jdolan · claude · jdolan · commit f8a558c63f8c · 2026-06-29T16:25:26.000-04:00
Parallel multi-project builds (e.g. quetoo_all.sln with msbuild /m) import
this target into several projects at once, racing on the same download.
Guard the fetch with a named mutex and an inner existence re-check so only
one project downloads and the rest skip.

Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/ObjectivelyGPU.vs15/sdl3.targets b/ObjectivelyGPU.vs15/sdl3.targets
@@ -25,7 +25,7 @@
           Condition="!Exists('$(SDL3Dir)include\SDL3\SDL.h')">
     <Message Importance="high" Text="Downloading SDL3 $(SDL3Version) development libraries..." />
     <Exec WorkingDirectory="$(MSBuildThisFileDirectory)"
-          Command="powershell -NoProfile -ExecutionPolicy Bypass -Command &quot;$ErrorActionPreference = 'Stop'; New-Item -ItemType Directory -Force libs | Out-Null; Invoke-WebRequest -Uri 'https://github.com/libsdl-org/SDL/releases/download/release-$(SDL3Version)/SDL3-devel-$(SDL3Version)-VC.zip' -OutFile 'libs\sdl3.zip'; Expand-Archive -Force 'libs\sdl3.zip' 'libs'; Remove-Item 'libs\sdl3.zip'&quot;" />
+          Command="powershell -NoProfile -ExecutionPolicy Bypass -Command &quot;$ErrorActionPreference = 'Stop'; $m = New-Object System.Threading.Mutex($false, 'Global\ObjectivelySDL3'); [void]$m.WaitOne(); try { if (-not (Test-Path '$(SDL3Dir)include\SDL3\SDL.h')) { New-Item -ItemType Directory -Force libs | Out-Null; Invoke-WebRequest -Uri 'https://github.com/libsdl-org/SDL/releases/download/release-$(SDL3Version)/SDL3-devel-$(SDL3Version)-VC.zip' -OutFile 'libs\sdl3.zip'; Expand-Archive -Force 'libs\sdl3.zip' 'libs'; Remove-Item 'libs\sdl3.zip' } } finally { $m.ReleaseMutex() }&quot;" />
   </Target>
 
 </Project>
diff --git a/Sources/ObjectivelyGPU.h b/Sources/ObjectivelyGPU.h
@@ -1,6 +1,6 @@
 /*
- * ObjectivelyGPU: SDL3 GPU wrapper for Objectively and GNU C.
- * Copyright (C) 2014 Jay Dolan <jay@jaydolan.com>
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
+ * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
  * warranty. In no event will the authors be held liable for any damages
diff --git a/Sources/ObjectivelyGPU/CommandBuffer.c b/Sources/ObjectivelyGPU/CommandBuffer.c
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/CommandBuffer.h b/Sources/ObjectivelyGPU/CommandBuffer.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/ComputePass.c b/Sources/ObjectivelyGPU/ComputePass.c
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/ComputePass.h b/Sources/ObjectivelyGPU/ComputePass.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/CopyPass.c b/Sources/ObjectivelyGPU/CopyPass.c
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/CopyPass.h b/Sources/ObjectivelyGPU/CopyPass.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/Framebuffer.c b/Sources/ObjectivelyGPU/Framebuffer.c
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/Framebuffer.h b/Sources/ObjectivelyGPU/Framebuffer.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/RenderDevice.c b/Sources/ObjectivelyGPU/RenderDevice.c
@@ -1,6 +1,6 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 GPU, SDL3 and GNU C.
- * Copyright (C) 2014 Jay Dolan <jay@jaydolan.com>
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
+ * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
  * warranty. In no event will the authors be held liable for any damages
diff --git a/Sources/ObjectivelyGPU/RenderDevice.h b/Sources/ObjectivelyGPU/RenderDevice.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/RenderPass.c b/Sources/ObjectivelyGPU/RenderPass.c
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
@@ -192,17 +192,17 @@ static void setBlendConstants(RenderPass *self, SDL_FColor blendConstants) {
 static void setScissor(RenderPass *self, const SDL_Rect *scissor) {
 
   if (scissor) {
-    const int x = SDL_clamp(scissor->x, 0, self->viewport.w);
-    const int y = SDL_clamp(scissor->y, 0, self->viewport.h);
-    const int r = SDL_clamp(scissor->x + scissor->w, 0, self->viewport.w);
-    const int b = SDL_clamp(scissor->y + scissor->h, 0, self->viewport.h);
-    self->scissor = (SDL_Rect) { .x = x, .y = y, .w = r - x, .h = b - y };
+    self->scissor = *scissor;
   } else {
+    // Reset to the full render target. RenderPass does not yet capture the
+    // target dimensions, so fall back to the current viewport, which the
+    // caller is expected to have set. This becomes a true target-size reset
+    // once Texture objects carry their dimensions into beginRenderPass.
     self->scissor = (SDL_Rect) {
-      self->viewport.x,
-      self->viewport.y,
-      self->viewport.w,
-      self->viewport.h
+      (int) self->viewport.x,
+      (int) self->viewport.y,
+      (int) self->viewport.w,
+      (int) self->viewport.h,
     };
   }
 
diff --git a/Sources/ObjectivelyGPU/RenderPass.h b/Sources/ObjectivelyGPU/RenderPass.h
@@ -1,5 +1,5 @@
 /*
- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.
+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.
  * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>
  *
  * This software is provided 'as-is', without any express or implied
diff --git a/Sources/ObjectivelyGPU/Types.h b/Sources/ObjectivelyGPU/Types.h
@@ -64,8 +64,10 @@ struct SDL_Size {
  * @details Unlike assert(3), this macro is never compiled out.
  */
 #define GPU_Assert(cond, fmt, ...) \
-  if (!(cond)) { \
-    SDL_LogCritical(SDL_LOG_CATEGORY_GPU, "%s::%d::%s: " fmt ": %s", __FILE__, __LINE__, __func__, ## __VA_ARGS__, SDL_GetError()); \
-    SDL_TriggerBreakpoint(); \
-    exit(EXIT_FAILURE); \
-  }
+  do { \
+    if (!(cond)) { \
+      SDL_LogCritical(SDL_LOG_CATEGORY_GPU, "%s::%d::%s: " fmt ": %s", __FILE__, __LINE__, __func__, ## __VA_ARGS__, SDL_GetError()); \
+      SDL_TriggerBreakpoint(); \
+      exit(EXIT_FAILURE); \
+    } \
+  } while (0)

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`/*`
`2`		`- * ObjectivelyGPU: SDL3 GPU wrapper for Objectively and GNU C.`
`3`		`- * Copyright (C) 2014 Jay Dolan <jay@jaydolan.com>`
	`2`	`+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.`
	`3`	`+ * Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>`
`4`	`4`	`*`
`5`	`5`	`* This software is provided 'as-is', without any express or implied`
`6`	`6`	`* warranty. In no event will the authors be held liable for any damages`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * ObjectivelyGPU: Object oriented MVC framework for SDL3 and GNU C.`
	`2`	`+ * ObjectivelyGPU: Object oriented graphics framework for SDL3 and GNU C.`
`3`	`3`	`* Copyright (C) 2026 Jay Dolan <jay@jaydolan.com>`
`4`	`4`	`*`
`5`	`5`	`* This software is provided 'as-is', without any express or implied`