Skip to content

Commit a4069f5

Browse files
committed
Auto merge of rust-lang#156257 - JonathanBrouwer:rollup-WThya34, r=JonathanBrouwer
Rollup of 3 pull requests Successful merges: - rust-lang#156251 (stdarch subtree update) - rust-lang#156151 (Don't return dummy MacroData in `get_macro`) - rust-lang#156211 (tests/ui: allow spaces in hashbrown src normalization)
2 parents 365c0e1 + 2744cb7 commit a4069f5

70 files changed

Lines changed: 41035 additions & 27119 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

compiler/rustc_resolve/src/build_reduced_graph.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ use crate::ref_mut::CmCell;
3838
use crate::{
3939
BindingKey, Decl, DeclData, DeclKind, DelayedVisResolutionError, ExternModule,
4040
ExternPreludeEntry, Finalize, IdentKey, LocalModule, MacroData, Module, ModuleKind,
41-
ModuleOrUniformRoot, ParentScope, PathResult, Res, Resolver, Segment, Used, VisResolutionError,
42-
errors,
41+
ModuleOrUniformRoot, ParentScope, PathResult, Res, Resolver, Segment, SyntaxExtension, Used,
42+
VisResolutionError, errors,
4343
};
4444

4545
impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
@@ -207,10 +207,11 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
207207
}
208208
}
209209

210-
pub(crate) fn get_macro(&self, res: Res) -> Option<&'ra MacroData> {
210+
/// Gets the `SyntaxExtension` corresponding to `res`.
211+
pub(crate) fn get_macro(&self, res: Res) -> Option<&Arc<SyntaxExtension>> {
211212
match res {
212-
Res::Def(DefKind::Macro(..), def_id) => Some(self.get_macro_by_def_id(def_id)),
213-
Res::NonMacroAttr(_) => Some(self.non_macro_attr),
213+
Res::Def(DefKind::Macro(..), def_id) => Some(&self.get_macro_by_def_id(def_id).ext),
214+
Res::NonMacroAttr(_) => Some(&self.non_macro_attr),
214215
_ => None,
215216
}
216217
}

compiler/rustc_resolve/src/lib.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1401,7 +1401,7 @@ pub struct Resolver<'ra, 'tcx> {
14011401
extern_macro_map: CacheRefCell<FxHashMap<DefId, &'ra MacroData>>,
14021402
dummy_ext_bang: Arc<SyntaxExtension>,
14031403
dummy_ext_derive: Arc<SyntaxExtension>,
1404-
non_macro_attr: &'ra MacroData,
1404+
non_macro_attr: Arc<SyntaxExtension>,
14051405
local_macro_def_scopes: FxHashMap<LocalDefId, LocalModule<'ra>> = default::fx_hash_map(),
14061406
ast_transform_scopes: FxHashMap<LocalExpnId, LocalModule<'ra>> = default::fx_hash_map(),
14071407
unused_macros: FxIndexMap<LocalDefId, (NodeId, Ident)>,
@@ -1821,8 +1821,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
18211821
extern_macro_map: Default::default(),
18221822
dummy_ext_bang: Arc::new(SyntaxExtension::dummy_bang(edition)),
18231823
dummy_ext_derive: Arc::new(SyntaxExtension::dummy_derive(edition)),
1824-
non_macro_attr: arenas
1825-
.alloc_macro(MacroData::new(Arc::new(SyntaxExtension::non_macro_attr(edition)))),
1824+
non_macro_attr: Arc::new(SyntaxExtension::non_macro_attr(edition)),
18261825
unused_macros: Default::default(),
18271826
unused_macro_rules: Default::default(),
18281827
single_segment_macro_resolutions: Default::default(),
@@ -1993,7 +1992,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
19931992
match macro_kind {
19941993
MacroKind::Bang => Arc::clone(&self.dummy_ext_bang),
19951994
MacroKind::Derive => Arc::clone(&self.dummy_ext_derive),
1996-
MacroKind::Attr => Arc::clone(&self.non_macro_attr.ext),
1995+
MacroKind::Attr => Arc::clone(&self.non_macro_attr),
19971996
}
19981997
}
19991998

@@ -2022,11 +2021,11 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
20222021
}
20232022

20242023
fn is_builtin_macro(&self, res: Res) -> bool {
2025-
self.get_macro(res).is_some_and(|macro_data| macro_data.ext.builtin_name.is_some())
2024+
self.get_macro(res).is_some_and(|ext| ext.builtin_name.is_some())
20262025
}
20272026

20282027
fn is_specific_builtin_macro(&self, res: Res, symbol: Symbol) -> bool {
2029-
self.get_macro(res).is_some_and(|macro_data| macro_data.ext.builtin_name == Some(symbol))
2028+
self.get_macro(res).is_some_and(|ext| ext.builtin_name == Some(symbol))
20302029
}
20312030

20322031
fn macro_def(&self, mut ctxt: SyntaxContext) -> DefId {

compiler/rustc_resolve/src/macros.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -882,7 +882,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
882882
}
883883
_ => None,
884884
},
885-
None => self.get_macro(res).map(|macro_data| Arc::clone(&macro_data.ext)),
885+
None => self.get_macro(res).map(Arc::clone),
886886
};
887887
Ok((ext, res))
888888
}
@@ -1212,7 +1212,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
12121212
// Reserve some names that are not quite covered by the general check
12131213
// performed on `Resolver::builtin_attrs`.
12141214
if name == sym::cfg || name == sym::cfg_attr {
1215-
let macro_kinds = self.get_macro(res).map(|macro_data| macro_data.ext.macro_kinds());
1215+
let macro_kinds = res.macro_kinds();
12161216
if macro_kinds.is_some() && sub_namespace_match(macro_kinds, Some(MacroKind::Attr)) {
12171217
self.dcx().emit_err(errors::NameReservedInAttributeNamespace { span, ident: name });
12181218
}

library/stdarch/.github/workflows/main.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ jobs:
104104

105105
# macOS targets
106106
- tuple: x86_64-apple-darwin
107-
os: macos-15-large
107+
os: macos-15-intel
108108
- tuple: x86_64-apple-ios-macabi
109-
os: macos-15-large
109+
os: macos-15-intel
110110
- tuple: aarch64-apple-darwin
111111
os: macos-15
112112
- tuple: aarch64-apple-ios-macabi
@@ -348,6 +348,7 @@ jobs:
348348
- name: Run miri tests
349349
env:
350350
TARGET: "aarch64-unknown-linux-gnu"
351+
RUSTFLAGS: "-Ctarget-cpu=neoverse-v3"
351352
run: |
352353
# read filters and join them with a space.
353354
FILTERS=$(cat aarch64-miri-tests.txt | tr '\n' ' ')

0 commit comments

Comments
 (0)