Refactor & code Cleanup in scenario#3346
Merged
Merged
Conversation
…pecific exceptions
…pecific exceptions
Mips2648
added a commit
that referenced
this pull request
May 14, 2026
Salvialf
approved these changes
May 18, 2026
zoic21
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on improving exception handling and code consistency in the
scenarioandscenarioExpressionclasses, as well as making minor improvements to type safety and return logic. The main changes involve consolidating exception handling to use\Throwable, refactoring logging calls to use a static method, and ensuring type consistency for timeout values.Exception Handling Improvements:
ExceptionandErrorwith a singlecatch (\Throwable $ex) inscenario.class.phpandscenarioExpression.class.php`Logging Refactor & code Cleanup::**
$this->setLogto use static methodself::setLoginscenarioExpression.class.php,waitstatic method to use the staticsetLogmethod, further standardizing logging practices.Type and Return Consistency:
getTimeoutmethod inscenario.class.phpto always return anintand removed the unused$_defaultparameter.setTimeoutmethod casts the timeout value tointbefore assignment for type safety.Minor Logic Fixes:
return $return;statement in theexportmethod to ensure the correct value is returned in all cases.Suggested changelog entry
Various bugfix & quality improvement
Related issues/external references
Fixes #
Types of changes
PR checklist