Do not use the foldername 'build' direct in the make file sources or targets#503
Open
de-wolff wants to merge 1 commit into
Open
Do not use the foldername 'build' direct in the make file sources or targets#503de-wolff wants to merge 1 commit into
de-wolff wants to merge 1 commit into
Conversation
uzi18
reviewed
Sep 4, 2021
| LD_SCRIPT2 := build/eagle.esphttpd2.v6.ld | ||
| LD_SCRIPT := $(BUILD_BASE)/eagle.esphttpd.v6.ld | ||
| LD_SCRIPT1 := $(BUILD_BASE)/eagle.esphttpd1.v6.ld | ||
| LD_SCRIPT2 := $(BUILD_BASE)/eagle.esphttpd2.v6.ld |
Contributor
There was a problem hiding this comment.
plus explicity add line
BUILD_BASE ?= build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this moment, when starting make with a different build folder (eg make BUILD_BASE other) this will result in an error.
This commit will correct this.