Fixes for repository detection on Windows (#136)

Merge pull request 136

Author: GICodeWarrior

jekyll-github-metadata.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").grep(%r!^(lib|bin)/!)
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "jekyll", ENV["JEKYLL_VERSION"] ? "~> #{ENV["JEKYLL_VERSION"]}" : "~> 3.1"
+  spec.add_runtime_dependency "jekyll", ENV["JEKYLL_VERSION"] ? "~> #{ENV["JEKYLL_VERSION"]}" : "~> 3.4"
   spec.add_runtime_dependency "octokit", "~> 4.0", "!= 4.4.0"
 
   spec.add_development_dependency "bundler", "~> 1.5"

lib/jekyll-github-metadata/repository_finder.rb

@@ -45,16 +45,12 @@ def nwo_from_config
         repo if repo && repo.is_a?(String) && repo.include?("/")
       end
 
-      def git_exe_path
-        ENV["PATH"].to_s
-          .split(File::PATH_SEPARATOR)
-          .map { |path| File.join(path, "git") }
-          .find { |path| File.exist?(path) }
-      end
-
       def git_remotes
-        return [] if git_exe_path.nil?
-        `#{git_exe_path} remote --verbose`.to_s.strip.split("\n")
+        _process, output = Jekyll::Utils::Exec.run("git", "remote", "--verbose")
+        output.to_s.strip.split("\n")
+      rescue Errno::ENOENT => e
+        Jekyll.logger.warn "Not Installed:", e.message
+        []
       end
 
       def git_remote_url

spec/repository_finder_spec.rb

@@ -77,12 +77,14 @@
     end
 
     context "when git doesn't exist" do
-      before(:each) { @old_path = ENV.delete("PATH").to_s.split(File::PATH_SEPARATOR) }
-      after(:each)  { ENV["PATH"] = @old_path.join(File::PATH_SEPARATOR) }
+      before(:each) do
+        @old_path = ENV["PATH"]
+        ENV["PATH"] = ""
+      end
+      after(:each)  { ENV["PATH"] = @old_path }
 
       it "fails with a nice error message" do
         allow(subject).to receive(:git_remote_url).and_call_original
-        expect(subject.send(:git_exe_path)).to eql(nil)
         expect(subject.send(:git_remote_url)).to be_empty
       end
     end