chore(docs): update code docs

Author: jellyrock[bot]

docs/components_ItemGrid_ItemGridOptions.bs.html

@@ -214,12 +214,12 @@
     m.favoriteMenu.iconUri = "pkg:/images/icons/favorite_selected.png"
     m.favoriteMenu.focusedIconUri = "pkg:/images/icons/favorite_selected.png"
     req = GetApi().BuildMarkFavoriteRequest(m.selectedFavoriteItem.id)
-    if isValid(req) then SubmitSideEffect(req)
+    SubmitSideEffect(req)
   else
     m.favoriteMenu.iconUri = "pkg:/images/icons/favorite.png"
     m.favoriteMenu.focusedIconUri = "pkg:/images/icons/favorite.png"
     req = GetApi().BuildUnmarkFavoriteRequest(m.selectedFavoriteItem.id)
-    if isValid(req) then SubmitSideEffect(req)
+    SubmitSideEffect(req)
   end if
   ' Make sure we set the Favorite Heart color for the appropriate child
   setHeartColor("#cc3333")

docs/components_ItemGrid_LoadVideoContentTask.bs.html

@@ -404,7 +404,14 @@
     end if
     ' Get transcoding reason
     video.transcodeReasons = getTranscodeReasons(m.playbackInfo.MediaSources[0].TranscodingUrl)
-    video.content.url = buildURL(m.playbackInfo.MediaSources[0].TranscodingUrl)
+    transcodingUrl = buildURL(m.playbackInfo.MediaSources[0].TranscodingUrl)
+    if not isValid(transcodingUrl)
+      m.log.error("Failed to build transcoding URL — server URL not set", "itemId", video.id)
+      m.top.errorMsg = translate(translationKeys.ErrorAnErrorWasEncounteredWhilePlaying)
+      video.content = invalid
+      return
+    end if
+    video.content.url = transcodingUrl
     video.isTranscoded = true
 
     ' If DoVi preservation caused this transcode, flag that direct play is a viable buffer-overflow fallback.
@@ -449,9 +456,21 @@
       ' if the domain of the URI is local to the server,
       ' create a new URI by appending the received path to the server URL
       ' later we will substitute the users provided URL for this case
-      if isValid(uri[4])
-        video.content.url = buildURL(uri[4])
+      if not isValid(uri[4])
+        m.log.error("Localhost stream has no path component", "sourceUrl", m.playbackInfo.MediaSources[0].Path)
+        m.top.errorMsg = translate(translationKeys.ErrorAnErrorWasEncounteredWhilePlaying)
+        video.content = invalid
+        return
+      end if
+
+      localUrl = buildURL(uri[4])
+      if not isValid(localUrl)
+        m.log.error("Failed to build localhost stream URL — server URL not set", "path", uri[4])
+        m.top.errorMsg = translate(translationKeys.ErrorAnErrorWasEncounteredWhilePlaying)
+        video.content = invalid
+        return
       end if
+      video.content.url = localUrl
     else
       ' External stream - use raw URL without modification
       fullyExternal = true
@@ -470,7 +489,14 @@
       params.MediaSourceId = mediaSourceId
     end if
 
-    video.content.url = buildURL(Substitute("Videos/{0}/stream", video.id), params)
+    streamUrl = buildURL(Substitute("Videos/{0}/stream", video.id), params)
+    if not isValid(streamUrl)
+      m.log.error("Failed to build stream URL — server URL not set", "itemId", video.id)
+      m.top.errorMsg = translate(translationKeys.ErrorAnErrorWasEncounteredWhilePlaying)
+      video.content = invalid
+      return
+    end if
+    video.content.url = streamUrl
   end if
 
   ' Apply Jellyfin authentication only for internal streams

docs/components_api_ApiTask.bs.html

@@ -67,6 +67,17 @@
     end if
   end if
 
+  if not isValid(req.url) or req.url = ""
+    print "[ApiTask] request rejected: url is invalid or empty"
+    return {
+      requestId: req.requestId,
+      ok: false,
+      statusCode: 0,
+      json: invalid,
+      text: ""
+    }
+  end if
+
   r = rr_Requests().request(method, req.url, args)
 
   return {

docs/components_api_SideEffectTask.bs.html

@@ -15,7 +15,15 @@
   authArgs = { headers: { Authorization: buildAuthHeader() }, timeout: 10000, useCache: false }
 
   ' Check if server supports fallback fonts
-  r = rr_Requests().get(buildURL("/system/configuration/encoding"), authArgs)
+  encodingUrl = buildURL("/system/configuration/encoding")
+  if not isValid(encodingUrl)
+    print "FontDownloadTask: Cannot build URL — server URL not set"
+    m.top.errorMessage = "Server URL not configured"
+    m.top.isFontDownloadSuccess = false
+    m.top.isFontDownloadCompleted = true
+    return
+  end if
+  r = rr_Requests().get(encodingUrl, authArgs)
   if not r.ok or not isValid(r.json) or not r.json.EnableFallbackFont
     print "FontDownloadTask: Server does not support fallback fonts"
     m.top.errorMessage = "Server does not support fallback fonts"
@@ -26,7 +34,15 @@
 
   ' Get list of available fonts
   re = CreateObject("roRegex", "Name.:.(.*?).,.Size", "s")
-  r = rr_Requests().get(buildURL("FallbackFont/Fonts"), authArgs)
+  fontsUrl = buildURL("FallbackFont/Fonts")
+  if not isValid(fontsUrl)
+    print "FontDownloadTask: Cannot build URL — server URL not set"
+    m.top.errorMessage = "Server URL not configured"
+    m.top.isFontDownloadSuccess = false
+    m.top.isFontDownloadCompleted = true
+    return
+  end if
+  r = rr_Requests().get(fontsUrl, authArgs)
   if not r.ok or r.text = ""
     print "FontDownloadTask: Failed to get font list from server"
     m.top.errorMessage = "Failed to get font list from server"

docs/components_mediaPlayers_AudioPlayer.bs.html

@@ -1387,7 +1387,7 @@
 
   ' Report playstate via side-effect task
   req = GetApi().BuildPlaystateRequest(state, params)
-  if isValid(req) then SubmitSideEffect(req)
+  SubmitSideEffect(req)
 
   m.log.debug("end ReportPlayback", state, int(m.top.position))
 end sub