chore(docs): update code docs

Author: jellyrock[bot]

docs/components_ItemDetails.bs.html

@@ -3095,6 +3095,7 @@
 
   if isValid(content) and content.count() > 0
     m.top.quickPlayNode = content[0]
+    m.top.quickPlayNode = invalid
   else
     m.log.warn("Series Play: could not load first episode for series", m.top.itemContent.id)
     m.global.sceneManager.callFunc("standardDialog", translate(translationKeys.ErrorPlaybackError), { data: ["<p>" + translate(translationKeys.ErrorCouldNotLoadTheFirstEpisode) + "</p>"] })
@@ -3129,6 +3130,7 @@
         return true
       else if focusedButton.id = "resumeButton" and isValid(m.top.nextUpEpisode) and isValidAndNotEmpty(m.top.nextUpEpisode.id)
         m.top.quickPlayNode = m.top.nextUpEpisode
+        m.top.quickPlayNode = invalid
         return true
       end if
     end if
@@ -3217,6 +3219,7 @@
   else if key = "play" and m.extrasGrid.hasFocus()
     if isValid(m.extrasGrid.focusedItem)
       m.top.quickPlayNode = m.extrasGrid.focusedItem
+      m.top.quickPlayNode = invalid
       return true
     end if
   end if
@@ -3228,6 +3231,19 @@
 ' Called automatically by SceneManager.popScene() / clearScenes()
 sub destroy()
   m.log.verbose("destroy")
+
+  ' Tear down ExtrasRowList FIRST — stops in-flight tasks (including any
+  ' LoadChannelProgramsTask started by onProgramsExpired) and unobserves all
+  ' fields before we destroy the texture manager or null out references.
+  m.extrasGrid.callFunc("destroy")
+
+  ' Unobserve m.port observers set by showScenes.bs CreateItemDetailsGroup().
+  ' These persist until the node is garbage collected, so explicit cleanup
+  ' prevents stale events from reaching main.bs's event loop after popScene.
+  m.top.unobserveField("quickPlayNode")
+  m.extrasGrid.unobserveField("selectedItem")
+  m.buttonGrp.unobserveField("buttonSelected")
+
   destroyTextureManager(m.extrasGrid.content)
 
   ' Safety net: stop the loading spinner in case the component is destroyed

docs/components_ItemGrid_BaseGridView.bs.html

@@ -1015,6 +1015,7 @@
       if isValid(m.channelFocused)
         m.log.debug("quickplay channel", "id", m.channelFocused.id, "type", m.channelFocused.type)
         m.top.quickPlayNode = m.channelFocused
+        m.top.quickPlayNode = invalid
         return true
       end if
     end if
@@ -1023,6 +1024,7 @@
 
     if isValid(itemToPlay)
       m.top.quickPlayNode = itemToPlay
+      m.top.quickPlayNode = invalid
       return true
     end if
   else if key = "left"

docs/components_extras_ExtrasRowList.bs.html

@@ -1052,6 +1052,9 @@
 
 sub onRowItemSelected()
   m.top.selectedItem = m.top.content.getChild(m.top.rowItemSelected[0]).getChild(m.top.rowItemSelected[1])
+  ' Clear immediately — prevents stale value from re-firing the m.port
+  ' observer when the parent ItemDetails screen is restored after popScene.
+  m.top.selectedItem = invalid
 end sub
 
 sub onRowItemFocused()
@@ -1125,6 +1128,67 @@
   end if
 end sub
 
+' destroy: Full teardown releasing all resources before component removal.
+' Called by ItemDetails.destroy() before nulling the extrasGrid reference.
+sub destroy()
+  ' Stop all in-flight tasks and unobserve their content fields
+  cancelInFlightChain()
+
+  ' Stop and release the program progress timer (inherited from JRRowList)
+  stopProgramProgressTicking(true)
+
+  ' Unobserve m.top fields set in init()
+  m.top.unobserveField("rowItemSelected")
+  m.top.unobserveField("rowItemFocused")
+  m.top.unobserveField("programsExpired")
+
+  ' Release task references
+  m.LoadSeasonsTask = invalid
+  m.LoadSeasonAllEpisodesTask = invalid
+  m.LoadSeasonEpisodesTask = invalid
+  m.LoadAdditionalPartsTask = invalid
+  m.LoadPeopleTask = invalid
+  m.LikeThisTask = invalid
+  m.SpecialFeaturesTask = invalid
+  m.LoadMoviesTask = invalid
+  m.LoadShowsTask = invalid
+  m.LoadSeriesTask = invalid
+  m.LoadBoxSetItemsTask = invalid
+  m.LoadArtistAlbumsTask = invalid
+  m.LoadArtistAppearsOnTask = invalid
+  m.LoadArtistSongsTask = invalid
+  m.LoadArtistSimilarTask = invalid
+  m.LoadAlbumSongsTask = invalid
+  m.LoadPlaylistItemsTask = invalid
+  m.LoadPhotoAlbumItemsTask = invalid
+  m.LoadChannelProgramsTask = invalid
+
+  ' Clear row references
+  m.rowChapters = invalid
+  m.rowAdditionalParts = invalid
+  m.rowSeasons = invalid
+  m.rowEpisodes = invalid
+  m.rowSeasonEpisodes = invalid
+  m.rowCast = invalid
+  m.rowLikeThis = invalid
+  m.rowSpecialFeatures = invalid
+  m.rowBoxSetItems = invalid
+  m.rowMovies = invalid
+  m.rowTvShows = invalid
+  m.rowSeries = invalid
+  m.rowArtistAlbums = invalid
+  m.rowArtistAppearsOn = invalid
+  m.rowArtistSongs = invalid
+  m.rowAlbumSongs = invalid
+  m.rowAlbumArtistAlbums = invalid
+  m.rowPlaylistItems = invalid
+  m.rowPhotoAlbumItems = invalid
+  m.rowChannelPrograms = invalid
+
+  ' Reset flags
+  m.isRefetchingChannelPrograms = false
+end sub
+
 ' onKeyEvent: Anticipate the next row on UP/DOWN so the panel translation animation starts
 ' in sync with the RowList floatingFocus animation rather than after it completes.
 ' Returns false so the RowList handles the actual navigation.

docs/components_home_FavoritesRows.bs.html

@@ -338,6 +338,9 @@
       itemToPlay = getItemAtIndices(m.top.rowItemFocused)
       if isValid(itemToPlay) and itemToPlay.type <> "Loading"
         m.top.quickPlayNode = itemToPlay
+        ' Clear immediately — same pattern as selectedItem. Prevents stale
+        ' value from re-firing when the screen is restored after playback.
+        m.top.quickPlayNode = invalid
       end if
       return true
     else if key = "replay"

docs/components_home_Home.bs.html

@@ -297,7 +297,9 @@
   m.top.selectedItem = msg.getData()
 end sub
 
-' Proxy quickPlayNode from whichever row list fires it
+' Proxy quickPlayNode from whichever row list fires it.
+' Must pass through invalid clears so Home.quickPlayNode doesn't retain
+' a stale value that re-fires the m.port observer on screen restoration.
 sub onQuickPlayNode(msg)
   m.top.quickPlayNode = msg.getData()
 end sub

docs/components_home_HomeRows.bs.html

@@ -193,16 +193,19 @@
     if section.type = "resume"
       if m.isLoadingResume then continue for
       m.isLoadingResume = true
+      m.LoadContinueWatchingTask.unobserveField("content")
       m.LoadContinueWatchingTask.observeField("content", "updateContinueWatchingItems")
       m.LoadContinueWatchingTask.control = "RUN"
     else if section.type = "nextup"
       if m.isLoadingNextUp then continue for
       m.isLoadingNextUp = true
+      m.LoadNextUpTask.unobserveField("content")
       m.LoadNextUpTask.observeField("content", "updateNextUpItems")
       m.LoadNextUpTask.control = "RUN"
     else if section.type = "livetv"
       if m.isLoadingOnNow then continue for
       m.isLoadingOnNow = true
+      m.LoadOnNowTask.unobserveField("content")
       m.LoadOnNowTask.observeField("content", "updateOnNowItems")
       m.LoadOnNowTask.control = "RUN"
     end if
@@ -783,6 +786,9 @@
       itemToPlay = getItemAtIndices(m.top.rowItemFocused)
       if isValid(itemToPlay) and itemToPlay.type <> "Loading"
         m.top.quickPlayNode = itemToPlay
+        ' Clear immediately — same pattern as selectedItem. Prevents stale
+        ' value from re-firing when the screen is restored after playback.
+        m.top.quickPlayNode = invalid
       end if
       return true
     else if key = "replay"
@@ -805,6 +811,7 @@
   ' Unobserve m.top fields
   m.top.unobserveField("rowItemSelected")
   m.top.unobserveField("rowItemFocused")
+  m.top.unobserveField("programsExpired")
 
   ' Stop and release all persistent task nodes
   m.LoadLibrariesTask.unobserveField("content")

docs/components_search_SearchResults.bs.html

@@ -169,6 +169,7 @@
         selectedItem = selectedContent.getChild(m.searchSelect.rowItemFocused[1])
         if isValid(selectedItem)
           m.top.quickPlayNode = selectedItem
+          m.top.quickPlayNode = invalid
           return true
         end if
       end if

docs/components_ui_rowlist_JRRowList.bs.html

@@ -37,6 +37,7 @@
   m.programProgressTimer = invalid
   m.observedContentRoot = invalid
   m.isProgramProgressTicking = false
+  m.suppressNextExpiry = false
 
   m.top.observeField("content", "onProgramProgressContentChanged")
 end sub
@@ -110,8 +111,13 @@
   m.isProgramProgressTicking = true
 
   ' Immediate refresh so returning from Settings/another screen does not
-  ' leave stale percentages on screen for up to 60 seconds.
+  ' leave stale percentages on screen for up to 60 seconds. Suppress expiry
+  ' detection on this first tick — the data is stale (from before the user
+  ' navigated away) and almost always contains expired programs, which would
+  ' trigger unnecessary refetches before the screen's own refresh has landed.
+  m.suppressNextExpiry = true
   onProgramProgressTick()
+  m.suppressNextExpiry = false
 end sub
 
 sub stopProgramProgressTicking(releaseTimer = false as boolean)
@@ -192,7 +198,11 @@
   end for
 
   if hasExpiredProgram
-    m.top.programsExpired = true
+    if m.suppressNextExpiry
+      m.suppressNextExpiry = false
+    else
+      m.top.programsExpired = true
+    end if
   end if
 end sub