Skip to content

Commit ae4fe31

Browse files
committed
Update code docs
1 parent 7f349b8 commit ae4fe31

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

docs/components_login_UserSelect.bs.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@
169169

170170
if key = "back"
171171
m.top.backPressed = true
172+
return true
172173
else if key = "up"
173174
if m.top.focusedChild.isSubType("JRButtonGroup")
174175
m.top.findNode("UserRow").setFocus(true)

docs/source_ShowScenes.bs.html

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@
2424
end if
2525

2626
m.serverSelection = "Saved"
27+
' Always ensure server select is on the stack before user select (for back button)
2728
if startOver or invalidServer
29+
' Need to show server select interactively
2830
print "Get server details"
2931
SendPerformanceBeacon("AppDialogInitiate") ' Roku Performance monitoring - Dialog Starting
3032
m.serverSelection = CreateServerGroup()
@@ -35,6 +37,15 @@
3537
return false
3638
end if
3739
SaveServerList()
40+
else
41+
' Server is valid - push placeholder to maintain consistent stack depth
42+
' This ensures the scene stack has the same depth regardless of whether
43+
' server selection UI was shown, preventing stack corruption on cleanup
44+
' Using Group because it has a visible field (ContentNode does not)
45+
print "Server valid, pushing placeholder to stack"
46+
placeholderNode = CreateObject("roSGNode", "Group")
47+
placeholderNode.visible = false
48+
m.global.sceneManager.callFunc("pushScene", placeholderNode)
3849
end if
3950

4051
localUser = m.global.user
@@ -94,8 +105,10 @@
94105
userSelected = CreateUserSelectGroup(publicUsersNodes)
95106
SendPerformanceBeacon("AppDialogComplete") ' Roku Performance monitoring - Dialog Closed
96107
if userSelected = "backPressed"
108+
' User wants to change server - clear all scenes and restart
97109
server.Delete()
98110
unset_setting("server")
111+
m.global.sceneManager.callFunc("clearScenes")
99112
goto start_login
100113
else if userSelected <> ""
101114
startLoadingSpinner()
@@ -417,6 +430,7 @@
417430
group.visible = false
418431
return -1
419432
else if isNodeEvent(msg, "backPressed")
433+
group.visible = false
420434
return "backPressed"
421435
else if type(msg) = "roSGNodeEvent" and msg.getField() = "userSelected"
422436
return msg.GetData()

0 commit comments

Comments
 (0)