Update code docs

Author: jellyrock-bot

docs/components_ItemGrid_LoadVideoContentTask.bs.html

@@ -47,7 +47,7 @@
   id = m.top.itemId
   mediaSourceId = invalid
   audio_stream_idx = m.top.selectedAudioStreamIndex
-  forceTranscoding = false
+  forceTranscoding = m.top.forceTranscoding
   bypassDoviPreservation = m.top.bypassDoviPreservation
 
   m.top.content = [LoadItems_VideoPlayer(id, mediaSourceId, audio_stream_idx, forceTranscoding, bypassDoviPreservation)]
@@ -221,7 +221,7 @@
   if meta.live then mediaSourceId = ""
 
   ' Call ItemPostPlaybackInfo ONCE with final subtitle_idx
-  m.playbackInfo = ItemPostPlaybackInfo(video.id, mediaSourceId, audio_stream_idx, subtitle_idx, playbackPosition, meta, bypassDoviPreservation)
+  m.playbackInfo = ItemPostPlaybackInfo(video.id, mediaSourceId, audio_stream_idx, subtitle_idx, playbackPosition, meta, bypassDoviPreservation, forceTranscoding)
   if not isValid(m.playbackInfo)
     video.errorMsg = "Error loading playback info"
     video.content = invalid
@@ -301,6 +301,7 @@
   if video.directPlaySupported
     video.isTranscoded = false
     setupVideoContentWithAuth(video, mediaSourceId, audio_stream_idx)
+    applyLiveDirectPlayFallback(video, meta)
   else
     if not isValid(m.playbackInfo.MediaSources[0].TranscodingUrl)
       ' If server does not provide a transcode URL, display a message to the user
@@ -425,20 +426,6 @@
   video.fullSubtitleData = safesubs
 end sub
 
-'
-' Extract array of Transcode Reasons from the content URL
-' @returns Array of Strings
-function getTranscodeReasons(url as string) as object
-
-  regex = CreateObject("roRegex", "&TranscodeReasons=([^&]*)", "")
-  match = regex.Match(url)
-
-  if match.count() > 1
-    return match[1].Split(",")
-  end if
-
-  return []
-end function
 
 function directPlaySupported(meta as object) as boolean
   devinfo = CreateObject("roDeviceInfo")

docs/components_video_VideoPlayerView.bs.html

@@ -542,10 +542,11 @@
   m.top.showID = videoContent[0].showID
   m.top.cachedPlaybackInfo = videoContent[0].playbackInfo
   m.top.doviDirectPlayFallbackAvailable = isValid(videoContent[0].doviDirectPlayFallbackAvailable) and videoContent[0].doviDirectPlayFallbackAvailable
+  m.top.transcodeAvailable = isValid(videoContent[0].transcodeAvailable) and videoContent[0].transcodeAvailable
 
-  ' Reset bypass flag so subsequent reloads (audio/subtitle changes) re-evaluate DoVi naturally.
-  ' It will be set back to true by the error handler if another buffer overflow occurs.
+  ' Reset retry flags so subsequent reloads (audio/subtitle changes) use fresh evaluation.
   m.LoadMetaDataTask.bypassDoviPreservation = false
+  m.LoadMetaDataTask.forceTranscoding = false
 
   if isValidAndNotEmpty(videoContent[0].json)
     m.osd.json = formatJson(videoContent[0].json)
@@ -879,6 +880,24 @@
   end if
 end sub
 
+' retryPlayback: Re-runs the content loader from the current position with updated task flags.
+' Used by error handlers to retry without exiting the player.
+' @param {boolean} bypassDovi - skips DoVi container profile so the server can grant direct play
+' @param {boolean} forceTranscode - disables direct play so the server returns a transcode URL
+sub retryPlayback(bypassDovi as boolean, forceTranscode as boolean)
+  m.global.queueManager.callFunc("setTopStartingPoint", int(m.top.position) * 10000000&)
+  ' Prevents ViewCreator popping the scene when stop causes Roku to fire "finished".
+  m.top.isRetrying = true
+  m.top.control = "stop"
+  m.LoadMetaDataTask.bypassDoviPreservation = bypassDovi
+  m.LoadMetaDataTask.forceTranscoding = forceTranscode
+  m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle
+  m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex
+  m.LoadMetaDataTask.itemId = m.currentItem.id
+  m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded")
+  m.LoadMetaDataTask.control = "RUN"
+end sub
+
 '
 ' When Video Player state changes
 sub onState()
@@ -909,19 +928,11 @@
     if isBufferLoopError and m.top.doviDirectPlayFallbackAvailable
       m.log.warn("Buffer overflow in DoVi transcode; falling back to direct play", m.currentItem.id)
       m.top.doviDirectPlayFallbackAvailable = false ' prevent retry loop if direct play also fails
-      m.global.queueManager.callFunc("setTopStartingPoint", int(m.top.position) * 10000000&)
-      ' Prevents ViewCreator popping the scene when stop causes Roku to fire "finished".
-      m.top.isRetrying = true
-      m.top.control = "stop"
-      m.LoadMetaDataTask.bypassDoviPreservation = true
-      m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle
-      m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex
-      m.LoadMetaDataTask.itemId = m.currentItem.id
-      m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded")
-      m.LoadMetaDataTask.control = "RUN"
+      retryPlayback(true, false)
     else if not m.playReported and m.top.transcodeAvailable
-      m.log.info("retrying with transcoding", m.currentItem.id, m.top.SelectedSubtitle, m.top.audioIndex)
-      m.top.retryWithTranscoding = true ' If playback was not reported, retry with transcoding
+      m.log.warn("Direct play failed; falling back to transcode", m.currentItem.id)
+      m.top.transcodeAvailable = false ' prevent retry loop if transcode also fails
+      retryPlayback(false, true)
     else
       ' If an error was encountered, stop timers and display dialog
       m.top.unobserveField("state")

docs/data/search.json

@@ -6,7 +6,7 @@
 import "pkg:/source/utils/deviceCapabilities.bs"
 import "pkg:/source/utils/misc.bs"
 
-function ItemPostPlaybackInfo(id as string, mediaSourceId = "" as string, audioTrackIndex = -1 as integer, subtitleTrackIndex = SubtitleSelection.none as integer, startTimeTicks = 0& as longinteger, videoMetadata = invalid as dynamic, bypassDoviPreservation = false as boolean)
+function ItemPostPlaybackInfo(id as string, mediaSourceId = "" as string, audioTrackIndex = -1 as integer, subtitleTrackIndex = SubtitleSelection.none as integer, startTimeTicks = 0& as longinteger, videoMetadata = invalid as dynamic, bypassDoviPreservation = false as boolean, forceTranscoding = false as boolean)
   globalUser = m.global.user
   postData = {
     "UserId": globalUser.id,
@@ -61,17 +61,7 @@
     postData.SubtitleStreamIndex = subtitleTrackIndex
   end if
 
-  ' Note: Jellyfin v10.9+ now remuxs LiveTV and does not allow DirectPlay anymore.
-  ' Because of this, we need to tell the server "EnableDirectPlay = false" so that we receive the
-  ' transcoding URL (which is just a remux and not a transcode; unless it is)
-  ' The web handles this by disabling EnableDirectPlay on a Retry, but we don't currently Retry a Live
-  ' TV stream, thus we just turn it off on the first try here.
-  if mediaSourceId <> ""
-    postData.MediaSourceId = mediaSourceId
-  else
-    ' No mediaSourceId? Must be LiveTV...
-    postData.EnableDirectPlay = false
-  end if
+  applyMediaSourceToPostData(postData, mediaSourceId, forceTranscoding)
 
   mediaStreams = invalid
   if isValid(videoMetadata) and isValid(videoMetadata.json) and isValid(videoMetadata.json.MediaStreams)
@@ -694,6 +684,24 @@
   return { Items: results }
 end function
 
+' applyMediaSourceToPostData: Applies the media source ID or live TV retry flags to a postData object.
+' Live TV is detected by an empty mediaSourceId. On the first attempt, direct play is not disabled
+' so the server can evaluate compatibility (matching web client behaviour). On retry,
+' forceTranscoding=true sets EnableDirectPlay=false so the server provides a transcode URL instead.
+'
+' @param {object} postData - The request body assoc array to modify
+' @param {string} mediaSourceId - Media source ID, or "" for live TV
+' @param {boolean} forceTranscoding - True when retrying with forced transcoding
+sub applyMediaSourceToPostData(postData as object, mediaSourceId as string, forceTranscoding as boolean)
+  if mediaSourceId <> ""
+    postData.MediaSourceId = mediaSourceId
+  else
+    if forceTranscoding
+      postData.EnableDirectPlay = false
+    end if
+  end if
+end sub
+
 ' Removes AAC from the device profile codec list to prevent stereo downmix of multichannel audio.
 ' Also handles unsupported AAC profiles (Main, HE-AAC).
 ' For stereo sources (≤2ch), also removes surround passthrough codecs (eac3, ac3, dts)