Skip to content

Commit f8dc702

Browse files
committed
Update code docs
1 parent 5cb5853 commit f8dc702

3 files changed

Lines changed: 15 additions & 44 deletions

File tree

docs/components_movies_MovieDetails.bs.html

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
m.deleteButton = invalid
4848

4949
m.isFirstRun = true
50-
m.allowButtonUpdates = true ' Allow button updates on init and when returning to screen
5150
m.top.observeField("itemContent", "itemContentChanged")
5251

5352
m.directorGenreGroup = m.top.findNode("directorGenreGroup")
@@ -95,7 +94,6 @@
9594
m.isFirstRun = false
9695
else
9796
' Trigger data refresh when returning to screen
98-
m.allowButtonUpdates = true ' Allow button updates for upcoming data refresh
9997
m.top.refreshMovieDetailsData = not m.top.refreshMovieDetailsData
10098
end if
10199
end sub
@@ -431,13 +429,8 @@
431429
SetUpAudioOptions(itemData.mediaStreams)
432430
updateOptionsButtonVisibility()
433431

434-
' Only manage resume button when explicitly allowed (initial load or returning to screen)
435-
' Prevents button changes during playback transition
436-
if m.allowButtonUpdates
437-
manageResumeButton()
438-
manageDeleteButton()
439-
m.allowButtonUpdates = false ' Disable until next OnScreenShown
440-
end if
432+
manageResumeButton()
433+
manageDeleteButton()
441434
end if
442435

443436
m.buttonGrp.visible = true

docs/components_ui_buttongroup_JRButtonGroup.bs.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
sub init()
77
m.top.layoutDirection = "horiz"
8-
m.top.itemSpacings = 24
8+
m.top.itemSpacings = 18
99

1010
m.top.buttonFocused = 0
1111

docs/source_Main.bs.html

Lines changed: 12 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -717,51 +717,23 @@
717717
group.lastFocus.setFocus(true)
718718
end if
719719
else if btn.id = "watchedButton"
720-
print "watchedButton pressed"
721720
movie = group.itemContent
722-
watchedButton = group.findNode("watchedButton")
723-
if isValid(movie) and isValid(movie.watched) and isValid(movie.id) and isValid(watchedButton)
724-
if movie.watched
721+
if isValid(movie) and isValid(movie.id)
722+
startLoadingSpinner()
723+
if isValid(movie.watched) and movie.watched
725724
UnmarkItemWatched(movie.id)
726-
movie.watched = false
727-
watchedButton.selected = false
728725
else
729726
MarkItemWatched(movie.id)
730-
movie.watched = true
731-
watchedButton.selected = true
732-
733-
' Remove Resume button when marking as watched (MovieDetails only)
734-
if group.subtype() = "MovieDetails"
735-
buttons = group.findNode("buttons")
736-
if isValid(buttons)
737-
resumeButton = buttons.findNode("resumeButton")
738-
if isValid(resumeButton)
739-
' Reset tick values before removing
740-
resumeButton.playbackPositionTicks = 0
741-
resumeButton.runtimeTicks = 0
742-
buttons.removeChild(resumeButton)
743-
744-
' Adjust focus index since we removed button at index 0
745-
' All other buttons shifted left by 1, so decrement focus index
746-
if buttons.buttonFocused > 0
747-
buttons.buttonFocused = buttons.buttonFocused - 1
748-
end if
749-
' Focus the target button directly (setFocus on the group doesn't reliably
750-
' update visuals when focus is already on a sibling child)
751-
focusTarget = buttons.getChild(buttons.buttonFocused)
752-
if isValid(focusTarget)
753-
focusTarget.setFocus(true)
754-
end if
755-
end if
756-
end if
757-
end if
758727
end if
728+
' Refresh from server to get authoritative state
729+
group.refreshMovieDetailsData = not group.refreshMovieDetailsData
759730
end if
760731
else if btn.id = "favoriteButton"
761732
print "favoriteButton pressed"
762733
movie = group.itemContent
763734
favoriteButton = group.findNode("favoriteButton")
764735
if isValid(movie) and isValid(movie.favorite) and isValid(movie.id) and isValid(favoriteButton)
736+
startLoadingSpinner()
765737
if movie.favorite
766738
UnmarkItemFavorite(movie.id)
767739
movie.favorite = false
@@ -771,6 +743,12 @@
771743
movie.favorite = true
772744
favoriteButton.selected = true
773745
end if
746+
stopLoadingSpinner()
747+
end if
748+
else if btn.id = "refreshButton"
749+
' Trigger data refresh for the current screen
750+
if isValid(group)
751+
group.refreshMovieDetailsData = not group.refreshMovieDetailsData
774752
end if
775753
else if btn.id = "deleteButton"
776754
print "deleteButton pressed"

0 commit comments

Comments
 (0)