fix(analytics): point jsdoc footer tracker at first-party /_a#46
Merged
Conversation
The jsdoc footer still embedded the Umami tracker cross-origin (analytics.jellyrock.app/script.js), even though the live site already serves it first-party. Under the static-site CSP (script-src 'self' [+ 'unsafe-inline' on the doc carve-out], ADR-0006) a cross-origin script source is blocked, so a future docs regeneration from this jsdoc.json would reintroduce the May-2026 analytics-blackout footgun on api. Sync the source to the first-party path used everywhere else: /_a/script.js plus data-host-url so events post to the same-origin /_a/api/send proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The jsdoc footer in
jsdoc.jsonstill embedded the Umami tracker cross-origin (analytics.jellyrock.app/script.js), even though the live api site already serves it first-party.Why it matters
Under the static-site CSP (
script-src 'self'— plus'unsafe-inline'on the doc-site carve-out, ADR-0006) a cross-origin script source is blocked. Nothing is broken right now (live + deployed output are already first-party), but a future docs regeneration from thisjsdoc.json(therepository_dispatchupdate.ymlpath) would reintroduce the cross-origin embed and re-create the May-2026 analytics-blackout footgun — on api only.Fix
Sync the source to the first-party path used everywhere else:
/_a/script.js+data-host-url="https://api.jellyrock.app/_a"so events post to the same-origin/_a/api/sendproxy.Source-only change —
deploy.ymlignoresjsdoc.json, so this doesn't deploy; it takes effect on the next docs regeneration. JSON validated.Note (out of scope)
The committed
docs/output is independently stale vs. live (no analytics footer at all in the committed HTML), and the live page also loads a cross-originhtml5shivfrom googlecode that the CSP blocks (harmless legacy IE shim). Flagging, not fixing here.