fix(jcasc): remove deprecated excludeClientIPFromCrumb + silence release-drafter (#2183)

* fix(jcasc): remove deprecated excludeClientIPFromCrumb attribute

DefaultCrumbIssuer no longer supports excludeClientIPFromCrumb in
newer Jenkins/JCasc versions, causing a fatal UnknownAttributesException
at startup. Replace with empty standard: {} block.

Also add a failure capture step in plugin_update.yml to surface Jenkins
logs when the workflow fails, improving diagnosability.

Signed-off-by: Bruno Verachten <gounthar@gmail.com>

* ci(release-drafter): disable automatic triggers

Same fix as applied to main: replace push/pull_request triggers with
workflow_dispatch to stop the action failing on every event due to the
zero-releases pagination bug in release-drafter.

Signed-off-by: Bruno Verachten <gounthar@gmail.com>

---------

Signed-off-by: Bruno Verachten <gounthar@gmail.com>

Author: gounthar

.github/workflows/plugin_update.yml

@@ -74,3 +74,12 @@ jobs:
               # Create pull request using gh command
               gh pr create --title "chore(jenkins): Updates Jenkins plugins" --body "This pull request updates the Jenkins plugins listed in \`plugins.txt\`." --base "$BASE_BRANCH" --head "$BRANCH_NAME"
           fi
+
+      - name: Capture Jenkins logs on failure
+        if: failure()
+        run: |
+          echo "=== Container status ==="
+          docker ps -a
+          echo "=== Jenkins controller logs ==="
+          CTRL=$(docker ps -a --format "{{.Names}}" | grep -m1 controller || true)
+          [ -n "$CTRL" ] && docker logs "$CTRL" 2>&1 | tail -200 || echo "No controller container found"

.github/workflows/release-drafter.yml

@@ -1,17 +1,7 @@
 name: Release Drafter
 
 on:
-  push:
-    # branches to consider in the event; optional, defaults to all
-    branches:
-      - main
-  # pull_request event is required only for autolabeler
-  pull_request:
-    # Only following types are handled by the action, but one can default to all as well
-    types: [opened, reopened, synchronize]
-  # pull_request_target event is required for autolabeler to support PRs from forks
-  # pull_request_target:
-  #   types: [opened, reopened, synchronize]
+  workflow_dispatch:
 
 permissions:
   contents: read

dockerfiles/jenkins.yaml

@@ -13,8 +13,7 @@ jenkins:
           password: "admin"
   authorizationStrategy: loggedInUsersCanDoAnything
   crumbIssuer:
-    standard:
-      excludeClientIPFromCrumb: false
+    standard: {}
   nodes:  
   - permanent:
       labelString: "docker jenkins agent"