Add commons-lang to JDK migration via OpenRewrite and fix metadata validation

Author: s4chinjha

plugin-modernizer-core/pom.xml

@@ -117,6 +117,10 @@
       <groupId>org.openrewrite</groupId>
       <artifactId>rewrite-xml</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.openrewrite.recipe</groupId>
+      <artifactId>rewrite-apache</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.openrewrite.recipe</groupId>
       <artifactId>rewrite-jenkins</artifactId>

plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml

@@ -239,6 +239,19 @@ recipeList:
       newFullyQualifiedTypeName: org.apache.commons.text.WordUtils
 ---
 type: specs.openrewrite.org/v1beta/recipe
+name: io.jenkins.tools.pluginmodernizer.MigrateCommonsLangToJdkApi
+displayName: Migrate commons-lang usage to JDK API
+description: Replace commons-lang utility methods with modern JDK API equivalents using OpenRewrite.
+tags: ['dependencies', 'migration']
+recipeList:
+  # Replace StringUtils methods with JDK equivalents
+  - org.openrewrite.apache.commons.lang.ApacheCommonsStringUtilsRecipes
+  # Replace isEmpty/isNotEmpty with JDK equivalents
+  - org.openrewrite.apache.commons.lang.IsNotEmptyToJdk
+  # Clean up unused imports after migration
+  - org.openrewrite.java.RemoveUnusedImports
+---
+type: specs.openrewrite.org/v1beta/recipe
 name: io.jenkins.tools.pluginmodernizer.MigrateToJenkinsBaseLineProperty
 displayName: Migrate pom to using jenkins.baseline property if bom is present
 description: Migrate pom to using jenkins.baseline property if bom is present.

plugin-modernizer-core/src/test/java/io/jenkins/tools/pluginmodernizer/core/recipes/DeclarativeRecipesTest.java

@@ -3504,6 +3504,75 @@ public String getHtml() {
                 """));
     }
 
+    @Test
+    void migrateCommonsLangToJdkApi() {
+        rewriteRun(
+                spec -> {
+                    var parser = JavaParser.fromJavaVersion().logCompilationWarningsAndErrors(true);
+
+                    collectRewriteTestDependencies().forEach(parser::addClasspathEntry);
+
+                    spec.recipeFromResource(
+                                    "/META-INF/rewrite/recipes.yml",
+                                    "io.jenkins.tools.pluginmodernizer.MigrateCommonsLangToJdkApi")
+                            .parser(parser);
+                },
+                // language=java
+                java("""
+        package org.apache.commons.lang3;
+        public class StringUtils {
+            public static String defaultString(String str) {
+                return str == null ? "" : str;
+            }
+            public static String defaultString(String str, String defaultStr) {
+                return str == null ? defaultStr : str;
+            }
+            public static boolean isEmpty(CharSequence cs) {
+                return cs == null || cs.length() == 0;
+            }
+            public static boolean isNotEmpty(CharSequence cs) {
+                return cs != null && cs.length() > 0;
+            }
+            public static String trim(String str) {
+                return str == null ? null : str.trim();
+            }
+            public static String strip(String str) {
+                return str == null ? null : str.strip();
+            }
+            public static String upperCase(String str) {
+                return str == null ? null : str.toUpperCase();
+            }
+            public static String lowerCase(String str) {
+                return str == null ? null : str.toLowerCase();
+            }
+        }
+        """),
+                // language=java
+                java("""
+        import org.apache.commons.lang3.StringUtils;
+
+        class MyComponent {
+            public String getDefault(String input) {
+                return StringUtils.defaultString(input);
+            }
+            public String getDefaultWithFallback(String input) {
+                return StringUtils.defaultString(input, "N/A");
+            }
+        }
+        """, """
+        import java.util.Objects;
+
+        class MyComponent {
+            public String getDefault(String input) {
+                return Objects.toString(input, "");
+            }
+            public String getDefaultWithFallback(String input) {
+                return Objects.toString(input, "N/A");
+            }
+        }
+        """));
+    }
+
     @Test
     void migrateToJUnit5() {
         rewriteRun(

scripts/validate_metadata.py

@@ -48,7 +48,7 @@
 
 # migration IDs
 valid_migration_ids = [
-    "io.jenkins.tools.pluginmodernizer.FetchMetadata,"
+    "io.jenkins.tools.pluginmodernizer.FetchMetadata",
     "io.jenkins.tools.pluginmodernizer.MergeGitIgnoreRecipe",
     "io.jenkins.tools.pluginmodernizer.UpdateScmUrl",
     "io.jenkins.tools.pluginmodernizer.SetupJenkinsfile",
@@ -94,6 +94,7 @@
     "io.jenkins.tools.pluginmodernizer.EnsureIndexJelly",
     "io.jenkins.tools.pluginmodernizer.MigrateTomakehurstToWiremock",
     "io.jenkins.tools.pluginmodernizer.MigrateCommonsLang2ToLang3AndCommonText",
+    "io.jenkins.tools.pluginmodernizer.MigrateCommonsLangToJdkApi",
     "io.jenkins.tools.pluginmodernizer.RemoveOldJavaVersionForModernJenkins",
     "io.jenkins.tools.pluginmodernizer.SwitchToRenovate",
     "io.jenkins.tools.pluginmodernizer.JavaxAnnotationsToSpotbugs",