Removes commons lang usage#693
Open
alecharp wants to merge 5 commits into
Open
Conversation
mawinter69
suggested changes
Jan 19, 2026
| protected UserDetails authenticate2(String username, String password) throws AuthenticationException { | ||
| // Check if the password length is less than 14 characters | ||
| if(FIPS140.useCompliantAlgorithms() && StringUtils.length(password) < 14) { | ||
| if(FIPS140.useCompliantAlgorithms() && password.length() < 14) { |
Member
Author
There was a problem hiding this comment.
I don't think it can be null based on the call stack.
Thanks @mawinter69 Co-Authored-By: Markus Winter <m.winter@sap.com>
Thanks @mawinter69 Co-Authored-By: Markus Winter <m.winter@sap.com>
1 task
Member
Author
mawinter69
approved these changes
Jan 23, 2026
|
just checked the build - failed test seems to be a flaky (?) build on windows has already passed. Perhaps @alecharp could resolve this merge conflict, there by causing a new commit - thus kicking off a new build. If all good, maybe we can merge this PR. (I am looking to the commons-lang2 removal) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseed #691.
This removes entirely any usage of commons lang.
The API plugin is still a transitive dependency coming from ionicons-api and configuration-as-code dependencies. Excluding it from the latter is breaking the build.
Testing done
I ran
mvn verifylocally.Submitter checklist