Use jenkins cards over bootstrap cards

[lewisbirks]

A follow up for jenkinsci/warnings-ng-plugin#2067 (review)

The main difference between this and the implementation in the jenkinsci/warnings-ng-plugin#2067 is that I haven't restricted the height of the card as this is for a page that is dedicated to these messages. That can be changed if wanted.

Testing done

Tested against the projects provided in https://github.com/uhafner/warnings-ng-plugin-devenv

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[uhafner]

The content looks fine! It produces a lot of duplication, though. See my comment in #420

The main difference between this and the implementation in the jenkinsci/warnings-ng-plugin#2067 is that I haven't restricted the height of the card as this is for a page that is dedicated to these messages.

An ideal UX would be: the info and error panels would fill the whole page (both 50% of the non-header area). Then one could scroll the content of each of these 50% views, but the side panel would stay unchanged. This is one of the annoying "features" in Jenkins that the side panel navigation is not fixed and scrolls away when the current page is scrolled. But I tried so many times to get this working without success.

[uhafner]

When we would merge #420 then your code would be much shorter:

<bs:page it="${it}">
        <j:if test="${size(it.errorMessages) > 0}">
          <l:card title="${%Error Messages}">
            <div class="bs5-console-output">
              <pre id="errors">
                <j:forEach var="message" items="${it.errorMessages}">
                  <div>
                    ${message}
                  </div>
                </j:forEach>
            </div>
          </l:card>
        </j:if>
</bs>
```

[lewisbirks]

done

[uhafner]

Ok, I merged #420. Can you please rebase or merge using the page tag?

[lewisbirks]

Ok, I merged #420. Can you please rebase or merge using the page tag?

Yeah, I won't be able to get round to it today, but I'll get it done tomorrow 🙂

[lewisbirks]

An ideal UX would be: the info and error panels would fill the whole page (both 50% of the non-header area). Then one could scroll the content of each of these 50% views, but the side panel would stay unchanged. This is one of the annoying "features" in Jenkins that the side panel navigation is not fixed and scrolls away when the current page is scrolled. But I tried so many times to get this working without success.

Gave it a go but wasn't able to get anything working, but then again styling isn't my strong point so maybe someone else will manage it eventually

[uhafner]

Thanks!