Skip to content

Remove body styling#521

Merged
uhafner merged 1 commit into
jenkinsci:mainfrom
janfaracik:remove-body-styling
Jun 13, 2026
Merged

Remove body styling#521
uhafner merged 1 commit into
jenkinsci:mainfrom
janfaracik:remove-body-styling

Conversation

@janfaracik

@janfaracik janfaracik commented Jun 13, 2026

Copy link
Copy Markdown
Member

Spotted in jenkinsci/jenkins#26863

This plugin overrides the background styling of body, which causes the background of the page to be ever so slightly different when changing between pages which use this plugin and those that don't.

Testing done

Before

Screenshot 2026-06-13 at 11 00 36

After

Screenshot 2026-06-13 at 11 00 57

(it's a very subtle difference)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@github-actions github-actions Bot requested a review from uhafner June 13, 2026 10:01
@github-actions

Copy link
Copy Markdown

☀️   Quality Monitor

Tests

   🚀   Integration Tests: ✅ successful — 10 passed $\textsf{(±0)}$
   ⛔   Architecture Tests: ✅ successful — 15 passed $\textsf{(±0)}$

Coverage for New Code

   〰️   Line Coverage: 100.00% — perfect 🎉
   ➰   Branch Coverage: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 84.21% $\textsf{(±0)}$ — 3 missed lines
   ➰   Branch Coverage: 100.00% $\textsf{(±0)}$ — perfect 🎉

Style

   CheckStyle   CheckStyle: No warnings $\textsf{(±0)}$
   PMD   PMD: No warnings $\textsf{(±0)}$
   ☕   Java Compiler: No warnings $\textsf{(±0)}$

Bugs

   SpotBugs   SpotBugs: No bugs $\textsf{(±0)}$
   🐛   Error Prone: No bugs $\textsf{(±0)}$

API Problems

   🚫   Revapi: No warnings $\textsf{(±0)}$

Vulnerabilities

   🛡️   OWASP Dependency Check: 212 vulnerabilities $\color{green}{\textsf{(+212)}}$ — error: 14, high: 56, normal: 135, low: 7

Software Metrics

   🌀   Cyclomatic Complexity: 8 (total)
   💭   Cognitive Complexity: 0 (total)
   ➿   N-Path Complexity: 8 (total)
   📏   Lines of Code: 104 (total)
   📝   Non Commenting Source Statements: 25 (total)
   🔗   Class Cohesion: 6.67% (maximum)
   ⚖️   Weight of Class: 20.00% (maximum)

📌 Reference Results

Delta reports computed against the reference results of f703a52 in workflow run 27355061011.

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result.

@uhafner uhafner added the bug Bugs or performance problems label Jun 13, 2026

@uhafner uhafner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I never noticed that before.

@uhafner uhafner merged commit ac29905 into jenkinsci:main Jun 13, 2026
30 of 31 checks passed
@janfaracik janfaracik deleted the remove-body-styling branch June 13, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants