Skip to content

Remove version from configuration-as-code dependency#7

Merged
szandala merged 2 commits into
jenkinsci:masterfrom
pascal-hofmann:remove-version-from-configuration-as-code-dependency
Jan 23, 2024
Merged

Remove version from configuration-as-code dependency#7
szandala merged 2 commits into
jenkinsci:masterfrom
pascal-hofmann:remove-version-from-configuration-as-code-dependency

Conversation

@pascal-hofmann

@pascal-hofmann pascal-hofmann commented Sep 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The plugin did not work with latest releases of configuration-as-code because it pinned to version 1.0.

@pascal-hofmann

pascal-hofmann commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

Hi @szandala, @jetersen!

Can I help to get this merged?

Cheers,
Pascal

jetersen
jetersen requested changes Jun 20, 2023
View reviewed changes
Comment thread pom.xml Outdated
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>3.18</version>
<version>4.46</version>

@jetersen jetersen Jun 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the newest?

Comment thread pom.xml Outdated
<properties>
<jenkins.version>2.60.3</jenkins.version>
<java.level>8</java.level>
<jenkins.version>2.319.3</jenkins.version>

@jetersen jetersen Jun 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really old baseline, please consider the following.
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/

Comment thread pom.xml Outdated
<jenkins.version>2.319.3</jenkins.version>
<useBeta>true</useBeta>
<access-modifier-checker.skip>true</access-modifier-checker.skip>
<plugin-bom.version>1607.va_c1576527071</plugin-bom.version>

@jetersen jetersen Jun 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property is not needed just move it to where it is used.

@jetersen

jetersen commented Jun 20, 2023

Copy link
Copy Markdown
Member

Did not notice the PR before you pinged but I would like to see these values updated at least. :)

@pascal-hofmann pascal-hofmann force-pushed the remove-version-from-configuration-as-code-dependency branch 2 times, most recently from bc362b2 to 5d634c2 Compare June 20, 2023 14:38
@pascal-hofmann pascal-hofmann requested a review from jetersen June 20, 2023 14:39
@pascal-hofmann

pascal-hofmann commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

Hi @jetersen,
by now I completely forgot what I did here and why. 😅

I tried to update my PR according to your comments. Can you have another look?

Cheers,
Pascal

@icep87

icep87 commented Sep 10, 2023

Copy link
Copy Markdown

@jetersen could you take a second look?

@icep87

icep87 commented Sep 11, 2023

Copy link
Copy Markdown

@jetersen can you maybe trigger the tests once again and merge this pr?

@jetersen

jetersen commented Sep 11, 2023

Copy link
Copy Markdown
Member

I think the Jenkins file needs updating 🤕

@icep87

icep87 commented Sep 11, 2023

Copy link
Copy Markdown

@pascal-hofmann any chance you could take a look?

@pascal-hofmann pascal-hofmann force-pushed the remove-version-from-configuration-as-code-dependency branch from 5d634c2 to 1e6bced Compare January 5, 2024 16:14
@pascal-hofmann pascal-hofmann force-pushed the remove-version-from-configuration-as-code-dependency branch from 96e979e to 5a62240 Compare January 5, 2024 16:31
@pascal-hofmann

pascal-hofmann commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

Sorry, this got buried under other things on my desk.

@jetersen Can you have another look? I assume my Jenkinsfile changes are not effective as I have not write access to the repo.

@pascal-hofmann

pascal-hofmann commented Jan 8, 2024

Copy link
Copy Markdown
Contributor Author

I just had a look at the logs. It really does ignore my Jenkinsfile.

[2024-01-05T16:31:40.257Z] Loading trusted files from base branch master at fd4f71096564a24f600e723b3263c4f973347c19 rather than 5a62240a3aa9c82f08b50b31ce960d6764389757
[2024-01-05T16:31:40.385Z] Obtained Jenkinsfile from fd4f71096564a24f600e723b3263c4f973347c19
[2024-01-05T16:31:40.607Z] ‘Jenkinsfile’ has been modified in an untrusted revision

@pascal-hofmann

pascal-hofmann commented Jan 17, 2024

Copy link
Copy Markdown
Contributor Author

Hi @jetersen,
can you have another look?

Cheers
Pascal

@pascal-hofmann

pascal-hofmann commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

Hi @szandala, @jetersen!

I fixed the jenkinsfile, but it's not used in the build because it's untrusted. I guess a maintainer needs to approve the changes so it gets used?

Cheers,
Pascal

@szandala szandala self-requested a review January 23, 2024 16:17
@szandala

szandala commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

I will merge this, but revert if it fails

@szandala szandala merged commit 740b832 into jenkinsci:master Jan 23, 2024
@pascal-hofmann

pascal-hofmann commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

Hmpf, this did not work. :(

It's a bit hard to test for me, without permission on the pipeline. Would be great if someone could have a look.

Thanks in advance,
Pascal

@szandala

szandala commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Tried here:
#9
Will try to look :-/

@pascal-hofmann pascal-hofmann deleted the remove-version-from-configuration-as-code-dependency branch September 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jetersen jetersen jetersen approved these changes
@szandala szandala szandala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pascal-hofmann @jetersen @icep87 @szandala