Fix JENKINS-71955 NullPointerException because getMergeRequestsEnabled is null#456
Merged
Merged
Conversation
NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "org.gitlab4j.api.models.Project.getMergeRequestsEnabled()" is null
basil
reviewed
Nov 6, 2024
| private static final String SOURCE_ID = "id"; | ||
|
|
||
| @Rule | ||
| public final RestartableJenkinsRule plan = new RestartableJenkinsRule(); |
Member
There was a problem hiding this comment.
Any particular reason to use RestartableJenkinsRule here over plain JenkinsRule?
Contributor
Author
There was a problem hiding this comment.
No particular reason. I changed the test to use JenkinsRule.
basil
approved these changes
Nov 8, 2024
jetersen
approved these changes
Nov 8, 2024
6 tasks
Member
|
Caused #460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://issues.jenkins.io/browse/JENKINS-71955
NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "org.gitlab4j.api.models.Project.getMergeRequestsEnabled()" is null
This is an alternative to #406 since this PR really fixes the NPE.
Note that the current title of JENKINS-71955 "GitLab branch source scan fails with null pointer exception if credentials are not provided" is misleading since the NPE also occurs when credentials are provided.
A null getMergeRequestsEnabled seems to be a very common situation, and I cannot find any workaround for this bug in our current Gitlab version (17.5).
According to https://github.com/gitlab4j/gitlab4j-api/blob/fe96001fd18d9411f5b4fbbeeca2377bb3791864/src/main/java/org/gitlab4j/api/ProjectApi.java#L1195
And according to https://docs.gitlab.com/ee/api/projects.html#create-a-project
Testing done
Added GitLabSCMSourceTest.java
Submitter checklist