Downgrade checkstyle for Java 17 support#233
Merged
krisstern merged 1 commit intoMay 23, 2026
Merged
Conversation
Checkstyle 13 requires Java 21 or newer. We can't use checjstyle 13 until the plugin requires Java 21 or newer. The plugin can't require Java 21 or newer until it requires Jenkins 2.541.1 or newer. https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#currently-recommended-versions recommends either 2.528.3 or 2.541.3. We generally prefer to choose the older of those two versions so that more users can upgrade their installed plugins with bug fixes and improvements. That page will recommend 2.541.3 and 2.555.3 in July 2026 when the next LTS baseline is released. Adds Java 17 to the test matrix so that future pull request proposals will fail if they attempt to require Java 21. When this is released, it will fix one of the failures in the plugin BOM release: * jenkinsci/bom#6837 Reverts pull requests: * jenkinsci#213 * jenkinsci#215 * jenkinsci#224 * jenkinsci#227 Testing done: * Confirmed that the code fails to compile with Java 17 before this change and compiles and tests successfully after this change
12 tasks
Member
|
Thanks, Mark! Appreciate the help |
krisstern
enabled auto-merge (squash)
May 23, 2026 13:17
krisstern
disabled auto-merge
May 23, 2026 19:04
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrade checkstyle for Java 17 support
Checkstyle 13 requires Java 21 or newer.
We can't use checkstyle 13 until the plugin requires Java 21 or newer. The plugin can't require Java 21 or newer until it requires Jenkins 2.541.1 or newer.
The developer doucmentation recommends either 2.528.3 or 2.541.3. We generally prefer to choose the older of those two versions so that more users can upgrade their installed plugins with bug fixes and improvements. That page will recommend 2.541.3 and 2.555.3 in July 2026 when the next LTS baseline is released.
Adds Java 17 to the test matrix so that future pull request proposals will fail if they attempt to require Java 21.
When this is released, it will fix one of the failures in the plugin BOM release:
Reverts pull requests:
Testing done
Submitter checklist