Allow merge request updates to cancel running builds from the same source branch

[manjukion]

Testing done

• Added/updated unit tests in PendinbBuildsHandlerTest
• Executed 'mvn spotless:apply'
• Executed 'mvn spotbugs:check'
• Executed 'mvn clean verify'
• Executed 'mvn clean package'
• Generated and installed the plugin HPI in a Jenkins test instance
• Verified that running builds triggered by the same merge request source branch are cancelled when the merge request is updated
• Verified the new help documentation renders correctly from the Jenkins job configuration page

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[Copilot]

Pull request overview

This PR adds an opt-in feature to abort currently running Jenkins builds when a GitLab merge request is updated, scoped to builds originating from the same source project ID and source branch. It extends the existing “cancel pending builds on update” behavior by also supporting in-flight build cancellation and updates UI/help/docs accordingly.

Changes:

• Introduces cancelRunningBuildsOnUpdate trigger option and wiring from config → handler.
• Renames/generalizes the pending-build cancellation helper to MergeRequestBuildHandler and adds running-build cancellation logic.
• Adds/updates documentation and tests for the new behavior.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/MergeRequestBuildHandler.java	Adds logic to abort running builds matching MR source project/branch and introduces a new interruption cause.
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/merge/MergeRequestHookTriggerHandlerImpl.java	Wires the new “cancel running builds on update” flag into MR update handling.
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/merge/MergeRequestHookTriggerHandlerFactory.java	Extends factory configuration to include the new flag (and updates config builder).
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/AbstractWebHookTriggerHandler.java	Switches from the old pending-build handler to the renamed MR build handler.
src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/push/OpenMergeRequestPushHookTriggerHandler.java	Updates call sites to use the renamed handler’s resolvePendingBuildName.
src/main/java/com/dabsquared/gitlabjenkins/MergeRequestTriggerConfig.java	Adds a default config method for the new flag.
src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java	Adds persisted field + getter/setter for cancelRunningBuildsOnUpdate.
src/main/resources/com/dabsquared/gitlabjenkins/GitLabPushTrigger/config.jelly	Adds UI checkbox for “Cancel running merge request builds on update”.
src/main/resources/com/dabsquared/gitlabjenkins/GitLabPushTrigger/help-cancelRunningBuildsOnUpdate.html	Adds help text for the new checkbox.
src/test/java/com/dabsquared/gitlabjenkins/trigger/handler/MergeRequestBuildHandlerTest.java	Adds a unit test for running-build cancellation behavior.
README.md	Documents the new configuration option and behavior.

Comments suppressed due to low confidence (3)

src/test/java/com/dabsquared/gitlabjenkins/trigger/handler/MergeRequestBuildHandlerTest.java:186

• otherBranchExec is never attached to the otherBranch run (you pass null as the executor), so the verify(otherBranchExec, never())... assertion is vacuous and won't catch accidental aborts. Pass the executor into runningBuildWithCause(...) so an incorrect abort would fail the test.
  src/test/java/com/dabsquared/gitlabjenkins/trigger/handler/MergeRequestBuildHandlerTest.java:190
• otherProjectExec is never attached to the otherProject run (you pass null as the executor), so the verify(otherProjectExec, never())... assertion is vacuous and won't catch accidental aborts. Pass the executor into runningBuildWithCause(...) so an incorrect abort would fail the test.
  src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/MergeRequestBuildHandler.java:74
• stopBuild(...) returns early when build.getExecutor() is null, but cancelRunningBuilds(...) still updates the GitLab commit status to canceled. This can leave the build running in Jenkins while reporting it as canceled in GitLab. Only update the commit status if the build was actually interrupted (or otherwise successfully stopped).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.