From f25179889396550f69a294a0b871710796d85848 Mon Sep 17 00:00:00 2001 From: tuev Date: Wed, 29 Jan 2020 14:30:35 +0300 Subject: [PATCH 1/2] add builds and connection params to UpdateGitlabCommitStatusStep # Conflicts: # src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java --- .../UpdateGitLabCommitStatusStep.java | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java b/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java index d1a350983..8d5ad4b1d 100644 --- a/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java +++ b/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java @@ -2,10 +2,13 @@ import com.dabsquared.gitlabjenkins.gitlab.api.model.BuildState; import com.dabsquared.gitlabjenkins.util.CommitStatusUpdater; +import edu.umd.cs.findbugs.annotations.NonNull; import hudson.Extension; import hudson.model.Run; import hudson.model.TaskListener; import hudson.util.ListBoxModel; + +import java.io.Serial; import java.util.Collections; import java.util.EnumSet; import java.util.HashSet; @@ -20,6 +23,11 @@ import org.kohsuke.stapler.DataBoundSetter; import org.kohsuke.stapler.export.ExportedBean; +import com.dabsquared.gitlabjenkins.connection.GitLabConnectionProperty; + +import java.util.ArrayList; +import java.util.List; + /** * @author Robin Müller */ @@ -28,6 +36,8 @@ public class UpdateGitLabCommitStatusStep extends Step { private String name; private BuildState state; + private List builds = new ArrayList() ; + private GitLabConnectionProperty connection; @DataBoundConstructor public UpdateGitLabCommitStatusStep(String name, BuildState state) { @@ -58,7 +68,26 @@ public void setState(BuildState state) { this.state = state; } + public List getBuilds() { + return builds; + } + + @DataBoundSetter + public void setBuilds(List builds) { + this.builds = builds; + } + + public GitLabConnectionProperty getConnection() { + return connection; + } + + @DataBoundSetter + public void setConnection(GitLabConnectionProperty connection) { + this.connection = connection; + } + public static class UpdateGitLabCommitStatusStepExecution extends AbstractSynchronousStepExecution { + @Serial private static final long serialVersionUID = 1; private final transient Run run; @@ -98,7 +127,7 @@ private TaskListener getTaskListener() { @Extension public static final class DescriptorImpl extends StepDescriptor { @Override - public String getDisplayName() { + public @NonNull String getDisplayName() { return "Update the commit status in GitLab"; } From 510295eb0b88d922f34a9783d1833fd4f9ca1f18 Mon Sep 17 00:00:00 2001 From: Kris Stern <88480540+krisstern@users.noreply.github.com> Date: Thu, 18 Jun 2026 00:21:02 +0800 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .../gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java b/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java index 8d5ad4b1d..1872abeda 100644 --- a/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java +++ b/src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java @@ -36,7 +36,7 @@ public class UpdateGitLabCommitStatusStep extends Step { private String name; private BuildState state; - private List builds = new ArrayList() ; + private List builds = new ArrayList<>(); private GitLabConnectionProperty connection; @DataBoundConstructor