Skip to content

add builds and connection params to UpdateGitlabCommitStatusStep #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krisstern wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add builds and connection params to UpdateGitlabCommitStatusStep #1911

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f251798
add builds and connection params to UpdateGitlabCommitStatusStep
MaksTuev Jan 29, 2020
510295e
Apply suggestions from code review
krisstern Jun 17, 2026
389bb7e
Merge branch 'master' into add_build_and_connections_params_for_updat…
krisstern Jun 17, 2026
baaf03b
Merge branch 'master' into add_build_and_connections_params_for_updat…
krisstern Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

import com.dabsquared.gitlabjenkins.gitlab.api.model.BuildState;
import com.dabsquared.gitlabjenkins.util.CommitStatusUpdater;
import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.Extension;
import hudson.model.Run;
import hudson.model.TaskListener;
import hudson.util.ListBoxModel;

import java.io.Serial;
import java.util.Collections;
import java.util.EnumSet;
import java.util.HashSet;
Expand All @@ -20,6 +23,11 @@
import org.kohsuke.stapler.DataBoundSetter;
import org.kohsuke.stapler.export.ExportedBean;

import com.dabsquared.gitlabjenkins.connection.GitLabConnectionProperty;

import java.util.ArrayList;
import java.util.List;

/**
* @author <a href="mailto:robin.mueller@1und1.de">Robin Müller</a>
*/
Expand All @@ -28,6 +36,8 @@ public class UpdateGitLabCommitStatusStep extends Step {

private String name;
private BuildState state;
private List<GitLabBranchBuild> builds = new ArrayList<>();
private GitLabConnectionProperty connection;

@DataBoundConstructor
public UpdateGitLabCommitStatusStep(String name, BuildState state) {
Expand Down Expand Up @@ -58,7 +68,26 @@ public void setState(BuildState state) {
this.state = state;
}

public List<GitLabBranchBuild> getBuilds() {
return builds;
}

@DataBoundSetter
public void setBuilds(List<GitLabBranchBuild> builds) {
this.builds = builds;
}

public GitLabConnectionProperty getConnection() {
return connection;
}

@DataBoundSetter
public void setConnection(GitLabConnectionProperty connection) {
this.connection = connection;
}
Comment on lines +75 to +87

public static class UpdateGitLabCommitStatusStepExecution extends AbstractSynchronousStepExecution<Void> {
@Serial
private static final long serialVersionUID = 1;

private final transient Run<?, ?> run;
Comment on lines 89 to 93
Expand Down Expand Up @@ -98,7 +127,7 @@ private TaskListener getTaskListener() {
@Extension
public static final class DescriptorImpl extends StepDescriptor {
@Override
public String getDisplayName() {
public @NonNull String getDisplayName() {
return "Update the commit status in GitLab";
}

Expand Down