automated plugin release by simonelbaz · Pull Request #404 · jenkinsci/openstack-cloud-plugin

simonelbaz · 2025-05-04T21:47:24Z

Testing done

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

-                                                @QueryParameter String zone,
-                                                @QueryParameter long cleanfreq
-						) {
+            public ListBoxModel doFillNameItems(


            @Restricted(DoNotUse.class)
            @RequirePOST
-            public FormValidation doCheckName(@QueryParameter String value,
+            public FormValidation doCheckName(


            @OsAuthDescriptor.InjectOsAuth
            @RequirePOST
-            public ListBoxModel doFillNameItems(@QueryParameter String name, @QueryParameter String endPointUrl, @QueryParameter boolean ignoreSsl, @QueryParameter String credentialsId, @QueryParameter String zone, @QueryParameter long cleanfreq) {
+            public ListBoxModel doFillNameItems(


            @Restricted(DoNotUse.class)
            @RequirePOST
-            public FormValidation doCheckName(@QueryParameter String value,
+            public FormValidation doCheckName(


mawinter69

looks good now from dependency side

mawinter69

the plugin still packs the jackson libraries. So you need to add exclusion to the 2 openstack4j dependencies:

        <exclusion>
          <groupId>com.fasterxml.jackson.core</groupId>
          <artifactId>*</artifactId>
        </exclusion>
        <exclusion>
          <groupId>com.fasterxml.jackson.databind</groupId>
          <artifactId>*</artifactId>
        </exclusion>
        <exclusion>
          <groupId>com.fasterxml.jackson.dataformat</groupId>
          <artifactId>*</artifactId>
        </exclusion>

and add a dependency to the jackson-api plugin

    <dependency>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>jackson2-api</artifactId>
    </dependency>

mawinter69 · 2025-05-21T14:40:53Z

+    <dependency>
+      <groupId>org.jenkins-ci.plugins</groupId>
+      <artifactId>cloud-stats</artifactId>
+      <version>377.vd8a_6c953e98e</version>


version can be removed as it is in the bom

mawinter69 · 2025-05-21T14:41:02Z

+    <dependency>
+      <groupId>org.jenkins-ci.plugins</groupId>
+      <artifactId>config-file-provider</artifactId>
+      <version>3.7.1</version>


version can be removed as it is in the bom

mawinter69 · 2025-05-21T14:41:44Z

+    <dependency>
+      <groupId>io.jenkins</groupId>
+      <artifactId>configuration-as-code</artifactId>
+      <version>1967.va_968e15fd05b_</version>


version can be removed as it is in the bom

mawinter69 · 2025-05-21T14:41:51Z

+    <dependency>
+      <groupId>io.jenkins.configuration-as-code</groupId>
+      <artifactId>test-harness</artifactId>
+      <version>1967.va_968e15fd05b_</version>


version can be removed as it is in the bom.

mawinter69 · 2025-05-21T14:49:20Z

-<!--        </dependency>-->
-    </dependencies>
+    <!-- Test Dependencies -->
+    <dependency>


hamcrest is provided by the parent pom. But removing this leads to test errors. So something to follow up on

mawinter69 · 2025-05-21T15:03:22Z

+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>


That is a quite old mockito version. So something to follow up on.

mawinter69 · 2025-05-21T15:27:16Z

+    <dependency>
+      <groupId>org.codehaus.plexus</groupId>
+      <artifactId>plexus-classworlds</artifactId>
+      <version>2.4.2</version>
+    </dependency>
+    <dependency>
+      <groupId>org.codehaus.plexus</groupId>
+      <artifactId>plexus-utils</artifactId>
+      <version>3.5.1</version>
+    </dependency>


Are the dependencies to plexus needed?
Tests are successful without them.

mawinter69 · 2025-05-21T15:36:55Z

-        </dependency>
+    <!-- Hardcoding upper-bound versions of dependencies -->
+    <dependency>
+      <groupId>org.jenkins-ci</groupId>


This dependency is not needed I think.

mawinter69 · 2025-05-21T15:37:04Z

-            <scope>test</scope>
-        </dependency>
+    <dependency>
+      <groupId>org.jenkins-ci</groupId>


This dependency is not needed I think.

mawinter69 · 2025-05-21T16:00:42Z

With all the deps removed the hpi is down from 7 MiB to 2 MiB

mawinter69

Please add an explicit dependency to

<dependency>
    <groupId>org.jenkins-ci.plugins</groupId>
    <artifactId>jackson2-api</artifactId>
</dependency>

Currently it will only work because dependent plugins depend on it as well.

mawinter69

Looks good from dependency perspective. Everything that is available as an api plugin is no longer packed in the hpi.

I can't really judge the other changes as I can't try out the plugin against a real openstack installation.

simonelbaz · 2025-05-21T21:14:59Z

Looks good from dependency perspective. Everything that is available as an api plugin is no longer packed in the hpi.

I can't really judge the other changes as I can't try out the plugin against a real openstack installation.

Thanks a lot. I am testing the #389 fix against a devstack instance.

simonelbaz self-assigned this May 4, 2025

simonelbaz marked this pull request as draft May 14, 2025 11:45

github-advanced-security AI found potential problems May 15, 2025

View reviewed changes

simonelbaz force-pushed the releaseplugingh branch 2 times, most recently from d5c315c to 998019a Compare May 19, 2025 13:41

simonelbaz marked this pull request as ready for review May 19, 2025 16:21

mawinter69 suggested changes May 19, 2025

View reviewed changes

Comment thread plugin/pom.xml Outdated

Comment thread plugin/pom.xml Outdated

Comment thread plugin/pom.xml Outdated

Comment thread plugin/pom.xml Outdated

mawinter69 reviewed May 20, 2025

View reviewed changes

Comment thread plugin/pom.xml Outdated

mawinter69 reviewed May 20, 2025

View reviewed changes

Comment thread plugin/pom.xml Outdated

mawinter69 approved these changes May 20, 2025

View reviewed changes

simonelbaz force-pushed the releaseplugingh branch from 69ec461 to 4953ddb Compare May 21, 2025 14:06

simonelbaz requested a review from mawinter69 May 21, 2025 14:31

mawinter69 suggested changes May 21, 2025

View reviewed changes

mawinter69 approved these changes May 21, 2025

View reviewed changes

simonelbaz force-pushed the releaseplugingh branch from fc50d66 to 4a4c77f Compare May 22, 2025 23:25

Fix jenkinsci#389

38bfe3c

simonelbaz force-pushed the releaseplugingh branch from 4a4c77f to 9ce7a9d Compare May 23, 2025 07:52

automated plugin release

8da67a9

simonelbaz force-pushed the releaseplugingh branch from 9ce7a9d to 8da67a9 Compare May 23, 2025 09:59

simonelbaz merged commit d2a20f9 into jenkinsci:releaseplugingh May 23, 2025
17 checks passed

simonelbaz deleted the releaseplugingh branch May 23, 2025 10:35

This was referenced May 25, 2025

chore(pom): Use recommended core version 2.462.3, and Java 11. #397

Closed

Stop testing Java 11 #390

Closed

Bump org.jenkins-ci.plugins:credentials from 1305.v04f5ec1f3743 to 1371.1373.v4eb_fa_b_7161e9 in /plugin #388

Closed

Uh oh!

Conversation

simonelbaz commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

Check warning

Check warning

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

mawinter69 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mawinter69 commented May 21, 2025

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

mawinter69 left a comment

Choose a reason for hiding this comment

Uh oh!

simonelbaz commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonelbaz commented May 4, 2025 •

edited

Loading

mawinter69 left a comment •

edited

Loading