Skip to content

Commit ffc8103

Browse files
authored
Enable spotless check (#176)
* Enable spotless check #175 intentionally disabled spotless checking so that the parent pom update could be merged. Enable spotless checking again. * Skip spotless formatting in two problem areas
1 parent 36e201d commit ffc8103

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.jenkins-ci.plugins</groupId>
77
<artifactId>plugin</artifactId>
8-
<version>5.12</version>
8+
<version>5.13</version>
99
<relativePath />
1010
</parent>
1111

@@ -29,7 +29,7 @@
2929
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
3030
<jenkins.baseline>2.479</jenkins.baseline>
3131
<jenkins.version>${jenkins.baseline}.3</jenkins.version>
32-
<spotless.check.skip>true</spotless.check.skip>
32+
<spotless.check.skip>false</spotless.check.skip>
3333
</properties>
3434

3535
<dependencyManagement>

src/main/java/hudson/plugins/plot/CSVSeries.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ private boolean excludePoint(final String label, int index) {
279279
}
280280

281281
boolean retVal =
282+
// spotless:off
282283
switch (inclusionFlag) {
283284
case INCLUDE_BY_STRING -> !checkExclusionSet(label); // if the set contains it, don't exclude it.
284285
case EXCLUDE_BY_STRING -> checkExclusionSet(label); // if the set doesn't contain it, exclude it.
@@ -288,6 +289,7 @@ private boolean excludePoint(final String label, int index) {
288289
colExclusionSet.contains(index); // if the set doesn't contain it, don't exclude it.
289290
default -> false;
290291
};
292+
// spotless:on
291293

292294
if (LOGGER.isLoggable(Level.FINEST)) {
293295
LOGGER.finest(((retVal) ? "excluded" : "included") + " CSV Column: " + index + " : " + label);

src/main/java/hudson/plugins/plot/Plot.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@ private void generatePlot(boolean forceGenerate) {
895895
* Creates a Chart of the style indicated by getUrlStyle() using the given
896896
* dataset. Defaults to using createLineChart.
897897
*/
898+
// spotless:off
898899
private JFreeChart createChart(PlotCategoryDataset dataset) {
899900
return switch (ChartStyle.forName(getUrlStyle())) {
900901
case AREA ->
@@ -929,6 +930,7 @@ private JFreeChart createChart(PlotCategoryDataset dataset) {
929930
getURLTitle(), null, getYaxis(), dataset, VERTICAL, hasLegend(), true, false);
930931
};
931932
}
933+
// spotless:on
932934

933935
/**
934936
* Returns a trimmed description string for the build specified by the given

0 commit comments

Comments
 (0)