Allow soft references in FlowExecutionListTest leak assertions#463
Merged
Conversation
jglick
approved these changes
Apr 20, 2026
14 tasks
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upcoming fix to
MemoryAssert.assertGCin jenkins-test-harness (jenkinsci/jenkins-test-harness#1029)) will causeassertGC(ref, false)to properly detect soft references. Without this change, these two tests would start failing once that fix landsThe soft references detected are from
java.beans.Introspectorand GroovyMetaClassinvocation caches which is standard JVM/Groovy caching unrelated to theStepExecutionIteratorcode under test. These tests still verify there are no strong reference leaksTesting done
Submitter checklist