Skip to content

Allow soft references in FlowExecutionListTest leak assertions#463

Merged
jglick merged 1 commit into
jenkinsci:masterfrom
RanjitCS:fix-assertgc-soft-ref
Apr 20, 2026
Merged

Allow soft references in FlowExecutionListTest leak assertions#463
jglick merged 1 commit into
jenkinsci:masterfrom
RanjitCS:fix-assertgc-soft-ref

Conversation

@RanjitCS

Copy link
Copy Markdown
Contributor

An upcoming fix to MemoryAssert.assertGC in jenkins-test-harness (jenkinsci/jenkins-test-harness#1029)) will cause assertGC(ref, false) to properly detect soft references. Without this change, these two tests would start failing once that fix lands

The soft references detected are from java.beans.Introspector and Groovy MetaClass invocation caches which is standard JVM/Groovy caching unrelated to the StepExecutionIterator code under test. These tests still verify there are no strong reference leaks

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jglick jglick added the tests label Apr 20, 2026
@jglick
jglick merged commit 2ccf579 into jenkinsci:master Apr 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants